600433 - shlibsign not run when packaging i386/x86_64 universal build (no fips support)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

make package
 in dir /builds/slave/mozilla-central-macosx64/build/obj-firefox/i386 (timeout 1200 secs)
Creating package directory...
/tools/buildbot/bin/python2.6 /builds/slave/mozilla-central-macosx64/build/config/optimizejars.py --optimize ../../dist/jarlog/ ../../dist/bin/chrome ../../dist/universal/firefox/chrome
No jar logs found in ../../dist/jarlog/. No jars to optimize.
signing nss libraries
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
Removing unpackaged files...

The utility can be found in obj-firefox/x86_64/dist/bin/shlibsign but not the i386 equivalent.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

FIPS support blocks 4.0 final I would say.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'll take this.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 490479 [details] [diff] [review]
Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.

I haven't actually tested this, but I think this does it.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 490479 [details] [diff] [review]
Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.

I was going to say you should just fix packager.mk, but it uses `uname -p`, and on OS X 10.6 that's still i386, so this should be fine.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/885574b5c18c