shlibsign not run when packaging i386/x86_64 universal build (no fips support)

RESOLVED FIXED in mozilla2.0b8

Status

P3
normal
RESOLVED FIXED
8 years ago
8 months ago

People

(Reporter: nthomas, Assigned: khuey)

Tracking

unspecified
mozilla2.0b8
x86
Mac OS X

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
make package
 in dir /builds/slave/mozilla-central-macosx64/build/obj-firefox/i386 (timeout 1200 secs)
Creating package directory...
/tools/buildbot/bin/python2.6 /builds/slave/mozilla-central-macosx64/build/config/optimizejars.py --optimize ../../dist/jarlog/ ../../dist/bin/chrome ../../dist/universal/firefox/chrome
No jar logs found in ../../dist/jarlog/. No jars to optimize.
signing nss libraries
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
run-mozilla.sh: Cannot execute ../../../i386/dist/bin/shlibsign.
Removing unpackaged files...

The utility can be found in obj-firefox/x86_64/dist/bin/shlibsign but not the i386 equivalent.
(Reporter)

Comment 1

8 years ago
FIPS support blocks 4.0 final I would say.
blocking2.0: --- → ?
blocking2.0: ? → betaN+
I'll take this.
Assignee: nobody → khuey
Priority: -- → P3
Created attachment 490479 [details] [diff] [review]
Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.
Comment on attachment 490479 [details] [diff] [review]
Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.

I haven't actually tested this, but I think this does it.
Attachment #490479 - Flags: review?(ted.mielczarek)
Comment on attachment 490479 [details] [diff] [review]
Shlibsign should be built for i386 too in a UNIVERSAL_BUILD.

I was going to say you should just fix packager.mk, but it uses `uname -p`, and on OS X 10.6 that's still i386, so this should be fine.
Attachment #490479 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/885574b5c18c
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.