600454 - [Build repository] Remove WinCE/WinMo remnants

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/build/search?string=winmo
"Found 10 matching lines in 5 files"

/buildbot-configs/mozilla2-staging/config.py: obviously.
/tools/release/version-bump.pl: I assume so.
/talos/*.py: I don't know, I'm not familiar with talos.

***

http://mxr.mozilla.org/build/search?string=wince
"Found 39 matching lines in 11 files"

Maybe/Probably some clean-up to do there too!?

Comment 1

[[e-mail] (:bhearsum)]

If we need to remove to these because they impede something else, we'll do it. I think it's explicitly bad to remove them just for the sake of it. There's certainly a chance we'll be building for them again in the future.

Comment 2

[Ed Morley [:emorley]]

Reopening after chat with Ben on IRC, since support for WinCE has been all but eradicated from mozilla-central in bug 614720 - and if the code is ever needed in the future, it can be easily retrieved from hg.

The indexes for the MXR searches in comment 0 are out of date, so I just pulled the following repos and searched locally for |win(ce|mo)|:

http://hg.mozilla.org/build/buildbot-configs/
http://hg.mozilla.org/build/buildbotcustom/
http://hg.mozilla.org/build/tools/

Comment 3

[Ed Morley [:emorley]]

Attachment: Remove from buildbotcustom

Comment 4

[Ed Morley [:emorley]]

Attachment: Remove from build tools

--

Note: No WinCE/WinMo references are left in buildbot-configs; so after these two patches, should be done here.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 531116 [details] [diff] [review]
Remove from buildbotcustom

I need to run this through staging before landing because of some of the areas it touches.

Comment 6

[Ed Morley [:emorley]]

Thanks :-)

Comment 7

[Ed Morley [:emorley]]

The build tools patch still applies cleanly at the moment, but would someone be able to check it in before it rots please. Thanks!

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 531117 [details] [diff] [review]
Remove from build tools

http://hg.mozilla.org/build/tools/rev/04eeca20cc4a

Comment 9

[[e-mail] (:bhearsum)]

Attachment: unbitrotted buildbotcustom patch

I finally got a chance to test the buildbotcustom patch. I had to unbitrot it, but it tested out OK.

I've landed it on the default branch of buildbotcustom, and it'll make it's way to production during the next reconfig.

Comment 10

[Ed Morley [:emorley]]

Thanks Ben! 
Have a great weekend :-)

Comment 11

[[e-mail] (:bhearsum)]

This went to production today.

Comment 12

[Ed Morley [:emorley]]

The file release/updates/moz192-firefox-wince.cfg was deleted by my original patch, but wasn't in the final commit:
http://hg.mozilla.org/build/tools/rev/04eeca20cc4a

Was this intentional, or a case of patch vs import causing the delete to get omitted?

Thanks :-)

Comment 13

[[e-mail] (:bhearsum)]

(In reply to comment #12)
> The file release/updates/moz192-firefox-wince.cfg was deleted by my original
> patch, but wasn't in the final commit:
> http://hg.mozilla.org/build/tools/rev/04eeca20cc4a
> 
> Was this intentional, or a case of patch vs import causing the delete to get
> omitted?
> 
> Thanks :-)

Good catch, I just pushed that.

Comment 14

[Ed Morley [:emorley]]

Great, thanks :-)