[Build repository] Remove WinCE/WinMo remnants

RESOLVED FIXED

Status

defect
--
minor
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: emorley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

http://mxr.mozilla.org/build/search?string=winmo
"Found 10 matching lines in 5 files"

/buildbot-configs/mozilla2-staging/config.py: obviously.
/tools/release/version-bump.pl: I assume so.
/talos/*.py: I don't know, I'm not familiar with talos.

***

http://mxr.mozilla.org/build/search?string=wince
"Found 39 matching lines in 11 files"

Maybe/Probably some clean-up to do there too!?
If we need to remove to these because they impede something else, we'll do it. I think it's explicitly bad to remove them just for the sake of it. There's certainly a chance we'll be building for them again in the future.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Depends on: 614720
Blocks: 614720
No longer depends on: 614720
Reopening after chat with Ben on IRC, since support for WinCE has been all but eradicated from mozilla-central in bug 614720 - and if the code is ever needed in the future, it can be easily retrieved from hg.

The indexes for the MXR searches in comment 0 are out of date, so I just pulled the following repos and searched locally for |win(ce|mo)|:

http://hg.mozilla.org/build/buildbot-configs/
http://hg.mozilla.org/build/buildbotcustom/
http://hg.mozilla.org/build/tools/
Status: RESOLVED → REOPENED
OS: All → Windows CE
Resolution: WONTFIX → ---
Posted patch Remove from buildbotcustom (obsolete) — Splinter Review
Assignee: nobody → bmo
Status: REOPENED → ASSIGNED
Attachment #531116 - Flags: review?(bhearsum)
--

Note: No WinCE/WinMo references are left in buildbot-configs; so after these two patches, should be done here.
Attachment #531117 - Flags: review?(bhearsum)
Attachment #531117 - Flags: review?(bhearsum) → review+
Comment on attachment 531116 [details] [diff] [review]
Remove from buildbotcustom

I need to run this through staging before landing because of some of the areas it touches.
Attachment #531116 - Flags: feedback+
Thanks :-)
Keywords: checkin-needed
Whiteboard: [checkin needed just for build tools patch; rest needs staging]
The build tools patch still applies cleanly at the moment, but would someone be able to check it in before it rots please. Thanks!
Keywords: checkin-needed
Whiteboard: [checkin needed just for build tools patch; rest needs staging] → [buildbotcustom needs testing in staging]
I finally got a chance to test the buildbotcustom patch. I had to unbitrot it, but it tested out OK.

I've landed it on the default branch of buildbotcustom, and it'll make it's way to production during the next reconfig.
Attachment #531116 - Attachment is obsolete: true
Attachment #537184 - Flags: review+
Attachment #537184 - Flags: checked-in+
Attachment #531116 - Flags: review?(bhearsum)
Thanks Ben! 
Have a great weekend :-)
Whiteboard: [buildbotcustom needs testing in staging]
This went to production today.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
The file release/updates/moz192-firefox-wince.cfg was deleted by my original patch, but wasn't in the final commit:
http://hg.mozilla.org/build/tools/rev/04eeca20cc4a

Was this intentional, or a case of patch vs import causing the delete to get omitted?

Thanks :-)
(In reply to comment #12)
> The file release/updates/moz192-firefox-wince.cfg was deleted by my original
> patch, but wasn't in the final commit:
> http://hg.mozilla.org/build/tools/rev/04eeca20cc4a
> 
> Was this intentional, or a case of patch vs import causing the delete to get
> omitted?
> 
> Thanks :-)

Good catch, I just pushed that.
Great, thanks :-)
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.