Closed
Bug 600454
Opened 15 years ago
Closed 14 years ago
[Build repository] Remove WinCE/WinMo remnants
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sgautherie, Assigned: emorley)
References
Details
Attachments
(2 files, 1 obsolete file)
3.49 KB,
patch
|
bhearsum
:
review+
nthomas
:
checked-in+
|
Details | Diff | Splinter Review |
8.18 KB,
patch
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/build/search?string=winmo
"Found 10 matching lines in 5 files"
/buildbot-configs/mozilla2-staging/config.py: obviously.
/tools/release/version-bump.pl: I assume so.
/talos/*.py: I don't know, I'm not familiar with talos.
***
http://mxr.mozilla.org/build/search?string=wince
"Found 39 matching lines in 11 files"
Maybe/Probably some clean-up to do there too!?
Comment 1•15 years ago
|
||
If we need to remove to these because they impede something else, we'll do it. I think it's explicitly bad to remove them just for the sake of it. There's certainly a chance we'll be building for them again in the future.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 2•14 years ago
|
||
Reopening after chat with Ben on IRC, since support for WinCE has been all but eradicated from mozilla-central in bug 614720 - and if the code is ever needed in the future, it can be easily retrieved from hg.
The indexes for the MXR searches in comment 0 are out of date, so I just pulled the following repos and searched locally for |win(ce|mo)|:
http://hg.mozilla.org/build/buildbot-configs/
http://hg.mozilla.org/build/buildbotcustom/
http://hg.mozilla.org/build/tools/
Status: RESOLVED → REOPENED
OS: All → Windows CE
Resolution: WONTFIX → ---
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Comment 4•14 years ago
|
||
--
Note: No WinCE/WinMo references are left in buildbot-configs; so after these two patches, should be done here.
Attachment #531117 -
Flags: review?(bhearsum)
Updated•14 years ago
|
Attachment #531117 -
Flags: review?(bhearsum) → review+
Comment 5•14 years ago
|
||
Comment on attachment 531116 [details] [diff] [review]
Remove from buildbotcustom
I need to run this through staging before landing because of some of the areas it touches.
Attachment #531116 -
Flags: feedback+
Assignee | ||
Comment 6•14 years ago
|
||
Thanks :-)
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin needed just for build tools patch; rest needs staging]
Assignee | ||
Comment 7•14 years ago
|
||
The build tools patch still applies cleanly at the moment, but would someone be able to check it in before it rots please. Thanks!
Comment 8•14 years ago
|
||
Comment on attachment 531117 [details] [diff] [review]
Remove from build tools
http://hg.mozilla.org/build/tools/rev/04eeca20cc4a
Attachment #531117 -
Flags: checked-in+
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin needed just for build tools patch; rest needs staging] → [buildbotcustom needs testing in staging]
Comment 9•14 years ago
|
||
I finally got a chance to test the buildbotcustom patch. I had to unbitrot it, but it tested out OK.
I've landed it on the default branch of buildbotcustom, and it'll make it's way to production during the next reconfig.
Attachment #531116 -
Attachment is obsolete: true
Attachment #537184 -
Flags: review+
Attachment #537184 -
Flags: checked-in+
Attachment #531116 -
Flags: review?(bhearsum)
Assignee | ||
Comment 10•14 years ago
|
||
Thanks Ben!
Have a great weekend :-)
Whiteboard: [buildbotcustom needs testing in staging]
Comment 11•14 years ago
|
||
This went to production today.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•14 years ago
|
||
The file release/updates/moz192-firefox-wince.cfg was deleted by my original patch, but wasn't in the final commit:
http://hg.mozilla.org/build/tools/rev/04eeca20cc4a
Was this intentional, or a case of patch vs import causing the delete to get omitted?
Thanks :-)
Comment 13•14 years ago
|
||
(In reply to comment #12)
> The file release/updates/moz192-firefox-wince.cfg was deleted by my original
> patch, but wasn't in the final commit:
> http://hg.mozilla.org/build/tools/rev/04eeca20cc4a
>
> Was this intentional, or a case of patch vs import causing the delete to get
> omitted?
>
> Thanks :-)
Good catch, I just pushed that.
Assignee | ||
Comment 14•14 years ago
|
||
Great, thanks :-)
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•