Cu is not defined into PAC_handleError (nsPlacesAutoComplete.js)

RESOLVED FIXED

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

a lot of error in Error Console in Firefox nightly Gecko/20100928.

Error: Cu is not defined
Source File: jar:file:///C:/Program%20Files%20(x86)/Minefield/omni.jar!/components/nsPlacesAutoComplete.js
Line: 519


We should define Cu in nsPlacesAutoComlete.js.
Created attachment 479321 [details] [diff] [review]
fix
Assignee: nobody → m_kato
Attachment #479321 - Flags: review?
Attachment #479321 - Flags: review? → review?(sdwilsh)
Attachment #479321 - Flags: review?(sdwilsh)
Attachment #479321 - Flags: review+
Attachment #479321 - Flags: approval2.0+
it's a bit nonsense to define Cu but use components.utils jut above it... if you define the const use if everywhere otherwise replace Cu with Components.utils.
I don't really mind the mixed use of Cu/Components.utils, FWIW, but a patch that just changes the one use of Cu to Components.utils would be fine too.
Whiteboard: [needs landing]
Keywords: checkin-needed
(In reply to comment #3)
> I don't really mind the mixed use of Cu/Components.utils, FWIW, but a patch
> that just changes the one use of Cu to Components.utils would be fine too.

Gavin, should I replace Cu to Components.utils? If so, I update it and land this.
since it's a single instance please use Components.utils instead of defining Cu, I'm fine with landing that.
Created attachment 485265 [details] [diff] [review]
patch for check in
fwiw you should fix indentation of the second message line
(In reply to comment #7)
> fwiw you should fix indentation of the second message line

Oh, I already landed this.  I will push indent fix too
Created attachment 485266 [details] [diff] [review]
indent fix
Comment on attachment 485266 [details] [diff] [review]
indent fix

Macro, need r+ and a+?
Attachment #485266 - Flags: review?(mak77)
Also, original is laned.  If I should back out this, I will do it.

http://hg.mozilla.org/mozilla-central/rev/452fa9a39c8f
Comment on attachment 485266 [details] [diff] [review]
indent fix

you can land it, I'm not a driver but it's just indentation fix, a=me on it, thanks.
Attachment #485266 - Flags: review?(mak77) → review+
http://hg.mozilla.org/mozilla-central/rev/3a5b84a290d7
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.