600469 - Cu is not defined into PAC_handleError (nsPlacesAutoComplete.js)

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Makoto Kato [:m_kato]]

a lot of error in Error Console in Firefox nightly Gecko/20100928.

Error: Cu is not defined
Source File: jar:file:///C:/Program%20Files%20(x86)/Minefield/omni.jar!/components/nsPlacesAutoComplete.js
Line: 519


We should define Cu in nsPlacesAutoComlete.js.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Marco Bonardo [:mak]]

it's a bit nonsense to define Cu but use components.utils jut above it... if you define the const use if everywhere otherwise replace Cu with Components.utils.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I don't really mind the mixed use of Cu/Components.utils, FWIW, but a patch that just changes the one use of Cu to Components.utils would be fine too.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to comment #3)
> I don't really mind the mixed use of Cu/Components.utils, FWIW, but a patch
> that just changes the one use of Cu to Components.utils would be fine too.

Gavin, should I replace Cu to Components.utils? If so, I update it and land this.

Comment 5

[Marco Bonardo [:mak]]

since it's a single instance please use Components.utils instead of defining Cu, I'm fine with landing that.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: patch for check in

Comment 7

[Marco Bonardo [:mak]]

fwiw you should fix indentation of the second message line

Comment 8

[Makoto Kato [:m_kato]]

(In reply to comment #7)
> fwiw you should fix indentation of the second message line

Oh, I already landed this.  I will push indent fix too

Comment 9

[Makoto Kato [:m_kato]]

Attachment: indent fix

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 485266 [details] [diff] [review]
indent fix

Macro, need r+ and a+?

Comment 11

[Makoto Kato [:m_kato]]

Also, original is laned.  If I should back out this, I will do it.

http://hg.mozilla.org/mozilla-central/rev/452fa9a39c8f

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 485266 [details] [diff] [review]
indent fix

you can land it, I'm not a driver but it's just indentation fix, a=me on it, thanks.

Comment 13

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/mozilla-central/rev/3a5b84a290d7