600617 - test case - themes landing page sorts

Status: VERIFIED FIXED

(Testing Graveyard :: WebQA, defect)

Description

[Truman Smith [:truman]]

separate test case for each page.  The Ratings sort is not included.

Comment 1

[Truman Smith [:truman]]

Attachment: test sort option Created

Comment 2

[Truman Smith [:truman]]

Attachment: test sort option Name

Comment 3

[Truman Smith [:truman]]

Attachment: test sort option Popular/Downloads

Comment 4

[Truman Smith [:truman]]

Attachment: test sort option Updated

Comment 5

[Truman Smith [:truman]]

(In reply to comment #0)
> separate test case for each page.  The Ratings sort is not included.

Supporting modules (page classes, utilities) in bug 599537

Comment 6

[Truman Smith [:truman]]

Attachment: test sort option Created

Comment 7

[Truman Smith [:truman]]

Attachment: test sort option Name

Comment 8

[Truman Smith [:truman]]

Attachment: test sort option Popular/Downloads

Comment 9

[Truman Smith [:truman]]

Attachment: test sort option Updated

Comment 10

[Tanay Gavankar [:tgavankar]]

Comment on attachment 480719 [details]
test sort option Created

put the themes_checked += 1 at the bottom of the loop so that it increments after the check actually occurs.

other than that looks ok.

one question: is there ever a time when themes_landing.get_theme_added_date_as_date() may return None? Because if there's an issue on the site where the dates are just not being displayed (or something where it would return None), the previous_date would keep getting defined to None, which would result in no exceptions being caught/saved (and so we wouldn't know anything's wrong).

Comment 11

[Truman Smith [:truman]]

(In reply to comment #10)
> Comment on attachment 480719 [details]
> test sort option Created
> 
> put the themes_checked += 1 at the bottom of the loop so that it increments
> after the check actually occurs.
> 
> other than that looks ok.
> 
> one question: is there ever a time when
> themes_landing.get_theme_added_date_as_date() may return None? Because if
> there's an issue on the site where the dates are just not being displayed (or
> something where it would return None), the previous_date would keep getting
> defined to None, which would result in no exceptions being caught/saved (and so
> we wouldn't know anything's wrong).

themes_landing.get_theme_added_date_as_date() should not return a None, in theory.  get_text should try to return some text and find_long_date should try to return a date type, and when they can't they should return an exception.

Comment 12

[Tanay Gavankar [:tgavankar]]

ok as long as an exception is thrown somewhere, that's fine

Comment 13

[Tanay Gavankar [:tgavankar]]

Comment on attachment 480720 [details]
test sort option Name

looks ok

Comment 14

[Truman Smith [:truman]]

commit r75396