Closed Bug 600699 Opened 15 years ago Closed 11 years ago

Remove downvotes from collections

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
4.x (triaged)

People

(Reporter: jbalogh, Assigned: chenba)

Details

(Whiteboard: [z])

You can hide this on the frontend and we can call it good. Or file another bug to get it removed from Python, which should be nice for our code deletion count.
Priority: -- → P5
Let's remove front and back
Assignee: nobody → chenba
Should the downvotes be removed from the collection_votes table as part of this? Any instructions regarding Collection.rating?
Initial attempt at removing collection downvotes: https://github.com/chenba/zamboni/commit/279810cc5f9f789b3678dfed028f0c798f9c60af. r? It doesn't remove the downvotes currently in the collection_votes table or do anything with ratings in collections. Although the next time someone votes, the rating will be updated with the value from the new downvote-less maths @ https://github.com/chenba/zamboni/commit/279810cc5f9f789b3678dfed028f0c798f9c60af#L8R35.
New commit with a couple edits: https://github.com/chenba/zamboni/commit/537a0c240d0bf9b1b23e26e395f95d64dbdd70d2. Mainly using names instead of a plain number on https://github.com/chenba/zamboni/commit/537a0c240d0bf9b1b23e26e395f95d64dbdd70d2#L13R238 The downvote field is not being dropped. Thanks, Andy.
What's the status on this? Are we waiting on anything? Thanks!
Thanks for filing this. Due to resource constraints we are closing bugs which we won't realistically be able to fix. If you have a patch that applies to this bug please reopen. For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.