Closed Bug 600714 Opened 14 years ago Closed 14 years ago

remove DDRAW junk from configure

Categories

(Firefox Build System :: General, defect)

x86
Windows Server 2003
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 500088 messed up and added a warning that's hit on all platforms. Since we don't care about Wince anymore, and that's the only places that cares about ddraw, we should just remove it.
Attachment #479597 - Flags: review?(vladimir)
(In reply to comment #0)
> Bug 500088 ... added a warning that's hit on all platforms.

non-WinCE Windows only.

***

http://mxr.mozilla.org/mozilla-central/search?string=CAIRO_HAS_DDRAW_SURFACE&case=1
Then I guess CAIRO_HAS_DDRAW_SURFACE code should be removed too, except in cairo/ and thebes/, iiuc.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
OS: All → Windows Server 2003
Hardware: All → x86
Yes, I will handle that separately.
Comment on attachment 479597 [details] [diff] [review]
patch

"approval2.0=?":
Dead (WinCE) DirectDraw configure support removal, zero risk.
Attachment #479597 - Flags: approval2.0?
Attachment #479597 - Flags: approval2.0? → approval2.0+
https://hg.mozilla.org/mozilla-central/rev/c6080277f397

I filed bug 606990 to remove the dead code.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Blocks: 606990
Flags: in-testsuite-
Comment on attachment 486030 [details] [diff] [review]
(Bv1) Missed cleanup, s/if/case/
[Moved to bug 607544]

Please file another bug.
Attachment #486030 - Attachment is obsolete: true
Attachment #486030 - Flags: review?(gavin.sharp)
Depends on: 607544
Attachment #486030 - Attachment description: (Bv1) Missed cleanup, s/if/case/ → (Bv1) Missed cleanup, s/if/case/ [Moved to bug 607544]
(In reply to comment #7)
> Please file another bug.

Bug 607544.
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.