600718 - Alive counter would inflate if blocklist is pinged more than once per 24 hours

Status: VERIFIED DUPLICATE of bug 620837

(Toolkit :: Add-ons Manager, defect)

Description

[Daniel Einspanjer [:dre] [:deinspanjer]]

One difference with our implementation of the alive counter vs Canonical's is that it is possible for our blocklist update check to happen more than once per day.  One way I can think to avoid that would be to omit the counter if it has been less than 24 hours since the last ping that included the counter. Seems like that would require another timestamp to be stored in prefs though..  any other thoughts?

Comment 1

[Robert Strong (they/them - no direct email)]

It is possible through code to initiate a second ping in 24 hours but this should be extremely rare (e.g. when I or another developer manually initiates a ping).
The interval is 86400 which equates to once per day
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/extensions.manifest#3

and

http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#69

Comment 2

[Daniel Einspanjer [:dre] [:deinspanjer]]

I guess I was being a little confused with the AUS timer which we have set to a higher level for nightlies.  So you don't think that it would be worth trying to handle the edge case of a user setting their blocklist interval to more than once per day?  If so, then you can close this as wontfix.

Comment 3

[Robert Strong (they/them - no direct email)]

I talked with Mossop about this briefly and don't think it is worth doing at this time but it would be very simple to implement so I'm leaving this open and we'll revisit whether we should or not when things aren't as busy.

Comment 4

[Robert Strong (they/them - no direct email)]

Daniel, is this bug still necessary now that bug 620837 is fixed?

Comment 5

[Robert Strong (they/them - no direct email)]

Talked with Daniel and he agreed that bug 620837 covers this case... resolving duplicate since bug 620837 implements this functionality