Show error messages in tweet reply box

RESOLVED FIXED in 2.2.5

Status

support.mozilla.org
Army of Awesome
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: williamr, Assigned: abuchanan)

Tracking

unspecified
2.2.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
We need to add two error messages for when a user clicks the submit button with an unexpected result. These messages should appear where the success message normally appears, they should be next to a red X instead of the green check mark.

1. Use case: Message contains more than 140 characters
- Error message: "Message is too long"
- Note: The tweet should not be sent if message is over 140 characters, so we must check for this before sending the tweet.

2. Use case: Message is not successfully sent via Twitter API
- Error message: "Sorry, an error occurred"
Target Milestone: --- → 2.2.5
(Assignee)

Comment 1

7 years ago
http://github.com/jsocol/kitsune/commit/36a6820ce0eaff10e4c8971c7df6f9acc67e6a6c
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Created attachment 480803 [details]
Post-fix screenshot, (part 1): "Message too long" error condition
I haven't yet figured out how to test part 2; I've put:

127.0.0.1 *.twitter.com in my HOSTS file, and it still goes through.  Suggestions welcome.
You need to log in before you can comment on or make changes to this bug.