Closed Bug 600741 Opened 9 years ago Closed 9 years ago

make search test more robust

Categories

(Firefox Graveyard :: Panorama, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iangilman, Assigned: iangilman)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Our search test fails if the original tab is still loading (for instance, if the previous test has just exited private browsing) when it starts. 

In addition, it's dependent upon the original tab's title being the same as a blank tab's title. I suppose that's reasonably safe, but we might as well control the titles of the tabs we're searching on.
Attached patch patch v1Splinter Review
Attachment #479638 - Flags: feedback?(raymond)
Comment on attachment 479638 [details] [diff] [review]
patch v1

Looks good to me.  Thanks!
Attachment #479638 - Flags: feedback?(raymond) → feedback+
Attachment #479638 - Flags: review?(dolske)
Blocks: 597043
Priority: -- → P2
Attachment #479638 - Flags: review?(dolske) → review+
Attachment #479638 - Flags: approval2.0?
Comment on attachment 479638 [details] [diff] [review]
patch v1

(tests don't need approval!)
Attachment #479638 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/20d28b1e4902
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.