Closed Bug 600781 Opened 14 years ago Closed 14 years ago

TM: untangle TraceRecorder::getCharAt

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

The control-flow in TraceRecorder::getCharAt() is horrible -- particularly the way that the 2nd branch's label is set -- and it's impeding my efforts in bug 600779.  This patch cleans it up.  The condition that is now called 'inRange' occurs slightly earlier in the LIR stream than previously, otherwise things are unchanged.

dvander, I'm r?ing you because 'hg blame' tells me you were the last to make significant changes to this function.
Attachment #479699 - Flags: review?(dvander)
Attachment #479699 - Attachment is patch: true
Attachment #479699 - Attachment mime type: application/octet-stream → text/plain
Attachment #479699 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/4bb4426eceef
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/4bb4426eceef
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.