Closed
Bug 600860
Opened 14 years ago
Closed 14 years ago
Add application role to distinguish our more interactive xul pages
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: davidb, Assigned: davidb)
Details
(Keywords: access)
Attachments
(1 file)
1.71 KB,
patch
|
enndeakin
:
review+
MarcoZ
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
We need this for about:addons and about:preferences so that screen readers don't mess up their buffers. Details: at least one major screen reader does not trust the application role that we already expose for xul documents through accessibility API, when it appears on an object inside an application. Instead, for Firefox, they look specifically for an application role object attribute as the best indicator. This means that for any XUL content that we load which does any significant mutation, we should add role="application". Patch attached. I'll request 2.0 approval if it passes review.
Attachment #479795 -
Flags: review?(enndeakin)
Updated•14 years ago
|
Attachment #479795 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 1•14 years ago
|
||
Comment on attachment 479795 [details] [diff] [review] trivial fix Requesting 2.0 approval. Patch is low risk and helps accessibility.
Attachment #479795 -
Flags: review?(marco.zehe)
Attachment #479795 -
Flags: approval2.0?
Comment 2•14 years ago
|
||
Comment on attachment 479795 [details] [diff] [review] trivial fix Approved for landing after b7
Attachment #479795 -
Flags: approval2.0? → approval2.0+
Comment 3•14 years ago
|
||
Comment on attachment 479795 [details] [diff] [review] trivial fix Yep this should do the trick!
Attachment #479795 -
Flags: review?(marco.zehe) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Note to self: add tests.
Assignee | ||
Comment 5•14 years ago
|
||
Thanks for landing Ehsan. http://hg.mozilla.org/mozilla-central/rev/9c6a08e1dae3
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•