browser_bookmarks.js | Test timed out

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Details

(Whiteboard: [mobile_unittests])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 479806 [details] [diff] [review]
patch

This is happening on my desktop Linux system because the target bookmark is scrolled below the bottom of the window.

The important line in the patch is:

  bookmarkitem.control.scrollBoxObject.ensureElementIsVisible(bookmarkitem);

The other changes (a) make sure that the location actually changes, by creating the tab with a different URI than the bookmark, and (b) rearrage some code to be in a more logical order.
Attachment #479806 - Flags: review?(mark.finkle)
Attachment #479806 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 1

8 years ago
http://hg.mozilla.org/mobile-browser/rev/bedc4384560b
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.