Closed Bug 600871 Opened 9 years ago Closed 9 years ago

browser_bookmarks.js | Test timed out

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

(Whiteboard: [mobile_unittests])

Attachments

(1 file)

Attached patch patchSplinter Review
This is happening on my desktop Linux system because the target bookmark is scrolled below the bottom of the window.

The important line in the patch is:

  bookmarkitem.control.scrollBoxObject.ensureElementIsVisible(bookmarkitem);

The other changes (a) make sure that the location actually changes, by creating the tab with a different URI than the bookmark, and (b) rearrage some code to be in a more logical order.
Attachment #479806 - Flags: review?(mark.finkle)
Attachment #479806 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/bedc4384560b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.