600885 - Add hashes to all objects on StAMO

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Description

[Wil Clouser [:clouserw]]

Static data is coming off StAMO.  We should figure out a way to flush it with Hera.

Also, once this bug is done, in production:  "Undo URL overrides in settings_local for USER_PIC_URL and anything else in there that is trying to avoid StAMO"

Comment 1

[Wil Clouser [:clouserw]]

Figuring out what is on StAMO and what isn't sounds like a pain so instead we'll just make sure anything on StAMO has a hash.  That will let us swap/complement StAMO with a 3rd party CDN with no troubles

Comment 2

[Andy McKay]

Changing settings_local to have:

ADDON_ICON_URL = ('%s/%s/%s/images/addon_icon/%%d/?modified=%%s' % (STATIC_URL, LANGUAGE_CODE, DEFAULT_APP))
PREVIEW_THUMBNAIL_URL = (STATIC_URL + '/img/uploads/previews/thumbs/%s/%d.png?modified=%d')
PREVIEW_FULL_URL = (STATIC_URL + '/img/uploads/previews/full/%s/%d.png?modified=%d')
USERPICS_URL = STATIC_URL + '/img/uploads/userpics/%s/%s/%s.png?modified=%d'

Will give hashed URLs. Added tests for the flushing of the URLs upon changes, but we'll need to be testing this in a more realistic environment.

https://github.com/jbalogh/zamboni/commit/e0ca93d188c014dcff6d3861426496d2e0343275

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this QA-testable, Wil?  (Is there potential fallout we could check for?)