600927 - GL extensions debugging info shouldn't be printed

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Neil Deakin]

A bunch of useless GL extensions junk is printed to the console after startup. It prints after the chrome page script has run, so I now have to scroll up to see the debugging info that I actually care about.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: remove GL extensions output

Yeah, I agree, the real question is does someone have a big use for this debug info right now (since I guess we can't keep it long-term anyway).

Seems to me like pretty internal stuff so someone wanting this info could get it from his debugger.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 479940 [details] [diff] [review]
remove GL extensions output

Worst case this should become #ifdef DEBUG..

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: only print GL stuff in debug builds

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 480261 [details] [diff] [review]
only print GL stuff in debug builds

a=me for checkin to b7

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/7365c436290e

Comment 6

[Neil Deakin]

This is not the correct fix for this. The useless debug info should NEVER be printed by default.

To make it worse, even more opengl junk about framebuffers is now being printed constantly, of which I, as a non-graphics developer, care nothing about. This makes it difficult to see the debugging info I do care about.

In addition, opengl debugging garbage is being printed to the JS console every time a window is opened.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Assigning to Vlad: you decide.

I don't even know if the JS console is really a JS console or is a general "error console" for all user-visible debugging needs.  Not feeling competent.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Huh?  It's not useless debug info, no more than assertions and other junk that we spew is printed.  It's also only printed once, so I don't see the problem.

What's being printed to the JS console?  I'm not aware of anything going there, and what "opengl junk about framebuffers" is being printed?

Regardless, it's a debug build.  It's full of spam already, most of which most people don't care about.  Complaining about spam that you don't care about is about as helpful as me complaining about spam that I don't care about, of which there is a lot!

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to comment #8)
> What's being printed to the JS console?  I'm not aware of anything going there,
> and what "opengl junk about framebuffers" is being printed?

If by "JS console" we mean the error console brought up by Ctrl+Shift+J, then I get this in there:

OpenGL LayerManager Initialized Succesfully.
Version: 3.2.0 NVIDIA 195.36.31
Vendor: NVIDIA Corporation
Renderer: Quadro FX 880M/PCI/SSE2
FBO Texture Target: TEXTURE_2D

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

(That part happens also in release builds).

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

That's output from the GL layer manager, which is the same output that the d3d layer manager prints.  It's probably not needed any more that we have that info in about:support, but removing it should go in a separate bug.

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

OK, Neil showed me his actual usage concern, and how our GL stuff is different from the rest:

Our GL debug stuff happens later than all the other debug stuff that litters his terminal. He is printing his own stuff for debugging, and that normally appears at the very end, which is convenient for him as he doesn't need to scroll back, EXCEPT that our GL stuff happens even after that, forcing him to scroll back.

I can think of 2 solutions:
 * we only print GL stuff in MOZ_GL_DEBUG mode. After all, we don't use that information that frequently. Especially the huge GL extensions dump.
 * we prefix our GL stuff by something greppable so he can use grep -v.

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

we can prefix, sure, that's fine

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

So, the approved patch here landed, but was apparently not the correct fix. Should it be backed out?

Comment 15

[Neil Deakin]

This doesn't happen anymore.