600957 - Have a way to provide mobile-browser-specific resources

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Some Android code (notifications, for example) requires images to be compiled into resources. We need a way to control that with easier customization.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: MOZ_ANDROID_RESOURCES_DIRECTORY variable

Added a new MOZ_ANDROID_RESOURCES_DIRECTORY variable to mobile confvars.sh.
It will be checked and used in the makefiles.

Comment 2

[Alex Pakhotin (:alexp)]

Attachment: Config changes for a new variable

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Config changes for a new variable

Alert service implementation for Android will be looking for MOZ_ANDROID_DRAWABLES variable, which could be provided in mobile/confvars.sh.

Comment 4

[(not currently active) Ted Mielczarek]

Why does this need to be a configure variable? From your usage in bug 601050, it looks like you could just do:
ifeq (Android,$(OS_TARGET))
ANDROID_DRAWABLES = ...
endif

in that Makefile. I don't see the need to put it in configure.

Comment 5

[Alex Pakhotin (:alexp)]

(In reply to comment #4)
> I don't see the need to put it in configure.

The idea is to make this variable available in the platform code. Here's where it's checked and used:
http://mxr.mozilla.org/mozilla-central/source/embedding/android/Makefile.in#167

The variable simply defined in m-b/confvars.sh is not visible in that Makefile unless it's propagated through the configure.

Well, I might be missing something here, and would be glad to know if this could be done some other way.

Comment 6

[(not currently active) Ted Mielczarek]

That code is all getting heavily mangled in bug 567873 anyway.

Comment 7

[Alex Pakhotin (:alexp)]

(In reply to comment #6)
> That code is all getting heavily mangled in bug 567873 anyway.

Yes, though I believe it's supposed to use the same approach for this bit. The app should be able somehow to define a list of drawable resources, which the packaging Makefile could pick up.

Comment 8

[(not currently active) Ted Mielczarek]

Hm. This is why we have packaging manifests, isn't it?

mwu: is there a better way to do this? This just feels wrong.

Comment 9

[Michael Wu [:mwu]]

(In reply to comment #8)
> Hm. This is why we have packaging manifests, isn't it?
> 
> mwu: is there a better way to do this? This just feels wrong.

Sure. We can take the approach from https://bugzilla.mozilla.org/show_bug.cgi?id=526333 and add a platform specific manifest.

Comment 10

[(not currently active) Ted Mielczarek]

Yeah, let's do that.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 480287 [details] [diff] [review]
Config changes for a new variable

Going to r- this for now, then.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 490229 [details] [diff] [review]
patch

I haven't be thrilled by this approach. There is a weird, undocumented connection between the platform installer and the app installer.

I guess this will work until something better comes along.

Comment 15

[Michael Wu [:mwu]]

Comment on attachment 490228 [details] [diff] [review]
patch

This is terrible but I don't have time right now to make something better.

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/4733aec2fa63 and http://hg.mozilla.org/mozilla-central/rev/f03f50294d9c