600986 - Persona background is seen above titlebar (Classic theme)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Persona theme + classic Windows theme

Spin off from bug 591930. See attached screenshot.

What happens is that the native drawing insets the gradient titlebar to position it accordingly to other windows on the system
http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsNativeThemeWin.cpp#3222

This leaves some transparent space above the titlebar, which is usually the window default background, but it can be the persona background-image too. I think the solution is just to paint the window default background color instead of leaving that transparent. I have a patch for that

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v1

Is this the right thing to do? I don't think it's possible to fix this with CSS since the titlebar is being natively drawn. I couldn't just move the titlebar up as the window border is also part of it (the transparent space falls between the edge and the gradient, all inside the #titlebar element)

(This should be good for review if it's the correct fix)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why is the persona background being positioned where it's not going to be visible?  Or is it visible in the titlebar space on other windows themes?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Technically it's because the area of the titlebar is drawn by us now (so it's part the client area), and the persona theme is just a background image applied to the #main-window.

On the Aero glass theme it's indeed visible in the titlebar space

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 479937 [details] [diff] [review]
Patch v1

I believe this is the right approach. switching feedback to review

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 479937 [details] [diff] [review]
Patch v1

works well. I'm kind of sad though, I considered that a cool feature, not a bug!

Comment 6

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/00c23130c7d1