601014 - Session Restore should never set the tab to both pinned and hidden

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Ian Gilman [:iangilman]]

See bug 597220. Relevant comment:

    sessionstore does restore pinned & hidden. We explicitly call pin/unPinTab,
    however we just set hidden directly. If that's a problem we can fix it.

Pinned should take precedence over hidden.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

So we should call hideTab before Pin/unPinTab?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> So we should call hideTab before Pin/unPinTab?

Yeah, that will give the correct behavior once bug 597218 is fixed.

Comment 3

[Ian Gilman [:iangilman]]

(In reply to comment #1)
> So we should call hideTab before Pin/unPinTab?

Actually it'd be more efficient to call pinTab before hideTab; hideTab just returns if the tab is already pinned (whereas the other way it would have to hide it and then un-hide it, and that only after bug 597218 lands).

Comment 4

[Ian Gilman [:iangilman]]

Looks like I'm going to fix this as part of bug 597218.

Comment 5

[Ian Gilman [:iangilman]]

bug 597218 has landed which contains the fix for this bug.