Closed
Bug 601026
Opened 14 years ago
Closed 13 years ago
buildbot: promote all-green deep builds to latest dir on asteam and copy to mozilla ftp
Categories
(Tamarin Graveyard :: Tools, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
Q4 11 - Anza
People
(Reporter: cpeyer, Assigned: jsudduth)
Details
Attachments
(1 file, 1 obsolete file)
12.28 KB,
patch
|
brbaker
:
review+
|
Details | Diff | Splinter Review |
Need to promote all-green deep builds on asteam/builds as well as ftp://ftp.mozilla.org/pub/js/tamarin/builds/
Reporter | ||
Comment 1•14 years ago
|
||
Note that the redux repo needs to be setup on the slave before running as the slave only pulls and updates the repo but does not delete/reclone in order to save time.
Attachment #479971 -
Flags: review?(brbaker)
Comment 2•14 years ago
|
||
Comment on attachment 479971 [details] [diff] [review] Add a promote-build builder that is dependent on the deep phase promote_build scheduler: - I am not 100% sure that this scheduler will wait until all builders in "deep" have completed cleanly. I "think" that you will see that Dependent.upstreamBuild() will be called each time one of the deep builders completes. promote_build_factory: - This should be setting up the build slave with the "promote-build" scripts, not the "windows" scripts . - The "Promote_Build" step should have a workdir="../repo/build/buildbot/slave/scripts". promote-build.sh - Can we echo the entire change description into the revision.txt instead of just the rev number? -echo "$change" > latest/revision.txt +hg log -v -r $change > latest/revision.txt * Actually would need to get back into the repo dir before this call. master.cfg - Can we add an email notification for when the "promote-build" scheduler completes?
Attachment #479971 -
Flags: review?(brbaker) → review-
Reporter | ||
Comment 3•14 years ago
|
||
Attachment #479971 -
Attachment is obsolete: true
Attachment #480171 -
Flags: review?(brbaker)
Reporter | ||
Comment 4•14 years ago
|
||
(In reply to comment #2) > promote_build scheduler: > - I am not 100% sure that this scheduler will wait until all builders in "deep" > have completed cleanly. I "think" that you will see that > Dependent.upstreamBuild() will be called each time one of the deep builders > completes. According to buildbot docs, a Dependent scheduler will only fire when all upstream builders complete successfully. > > promote_build_factory: > - This should be setting up the build slave with the "promote-build" scripts, > not the "windows" scripts . > - The "Promote_Build" step should have a > workdir="../repo/build/buildbot/slave/scripts". Fixed. > promote-build.sh > - Can we echo the entire change description into the revision.txt instead of > just the rev number? > -echo "$change" > latest/revision.txt > +hg log -v -r $change > latest/revision.txt > * Actually would need to get back into the repo dir before this call. revision.txt is actually used by the asc buildbot to pull the revision number from the latest dir. It could be changed in asc, but for now I'd like to leave as is. > > master.cfg > - Can we add an email notification for when the "promote-build" scheduler > completes? fixed.
Updated•14 years ago
|
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.2.x-Spicy
Comment 5•14 years ago
|
||
Comment on attachment 480171 [details] [diff] [review] Updated patch Looks good but I have one concern that does not require another review: What will bb_slaveupdate(slave="promote-build") do if the script dir already exists? This repo is never deleted so once this runs the first time the build/buildbot/slaves/scripts dir will exist. I think that you could remove this step and just have it be part of the required setup for this slave. Should add a readme.txt into the promote-build dir that describes the required setup for this slave: 1) tamarin-redux must be manually cloned as repo: >$ hg clone http://asteam.corp.adobe.com/hg/tamarin-redux/ repo 2) setup the "scripts" dir >$ cp -R build/buildbot/slaves/promote-build/scripts build/buildbot/slave/scripts
Attachment #480171 -
Flags: review?(brbaker) → review+
Comment 6•14 years ago
|
||
Looks like the repo pushes have not been recorded in this bug, but I just pushed a patch to tweak the most recent change so that the delete-bb-scripts-dir.sh script is called correctly: tamarin-redux 5346:8bb2c2be2db0
Updated•14 years ago
|
Target Milestone: flash10.2.x-Spicy → flash10.x - Serrano
Comment 7•14 years ago
|
||
changeset: 5703:faa391c48376 user: Brent Baker <brbaker@adobe.com> summary: Bug 601026: promote successful builds (r+brbaker) http://hg.mozilla.org/tamarin-redux/rev/faa391c48376
Comment 8•13 years ago
|
||
Status?
Updated•13 years ago
|
Assignee: cpeyer → jsudduth
Target Milestone: Q3 11 - Serrano → Q4 11 - Anza
Comment 9•13 years ago
|
||
cpeyer: Can this be closed? I thought this was all complete.
Reporter | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•