Closed Bug 601041 Opened 14 years ago Closed 14 years ago

JM: Clean up ExecPool and LinkBuffer usage

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

A bunch of places we are misusing RepatchBuffer and mishandling execpool refcounts on OOM. This patch fixes it all.
Attached patch fixSplinter Review
Attachment #479983 - Flags: review?(dmandelin)
To help review: A lot of the noise in this patch is |f.cx| changing to |cx|
Comment on attachment 479983 [details] [diff] [review]
fix

I love boilerplate reduction.
Attachment #479983 - Flags: review?(dmandelin) → review+
Apparently typing "hg qref tip" instead of "hg qfin tip" means you end up checking in an empty changeset.

http://hg.mozilla.org/tracemonkey/rev/1559a5982bf3
http://hg.mozilla.org/mozilla-central/rev/82d05bc1ef9c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.