601048 - Remove permanent headers from browser tool panels

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 600101 changed the layout of the browser tool panels, making the panel buttons always run across the top of the screen, portrait and landscape.

In landscape, the permanent header rows take up too much space, wasting it. We should remove permanent headers altogether. We should also add in-list headers, which can be scrolled away, where it makes sense. Preferences might be the only list where this would be beneficial.

Madhava - thoughts?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: WIP

Removes the permanent headers, but doesn't add any headers to the lists yet. Waiting for feedback. I also leave the strings in the code for now too. Waiting for feedback on adding or removing the strings to the buttons.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Created attachment 480088 [details] [diff] [review]
> WIP
> 
> Removes the permanent headers, but doesn't add any headers to the lists yet.
> Waiting for feedback. I also leave the strings in the code for now too. Waiting
> for feedback on adding or removing the strings to the buttons.

Adding the strings to the buttons is a good idea, this will allow us to have the look and feel of this mockup: http://mozilla.seanmartell.com/fennec/fimo/mockups-full-v7f.jpg

Comment 3

[Madhava Enros [:madhava]]

I think we need text titles for the categories.  Partly, ours may not be easy enough to clearly explain with just an icon, but this is likely even more true for others that get added by add-ons, so we need to have a space for them.

Realistically, there isn't enough room _in_ the category buttons.

How about replacing the current permanent titlebar with one that scrolls away, like our subsection headings?

Comment 4

[Madhava Enros [:madhava]]

to be clear, the top level row, though pannable-away, should be styled differently from subsection headings.  It should be blue, as in this mockup:
http://www.flickr.com/photos/madhava_work/4993642838/

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds pannable header rows. The rows are styled to be different than other row section headers. They will look better when the Android theme is complete, so I am not concerned with tweaking the style for now.

I had to add code to downloads so the header row was not removed when the list is filled.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/b6dd3807eb78

Comment 7

[Catalin Suciu [:csuciu]]

Verified as fixed on Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110913 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2