601088 - Feeds don't refresh

Status: VERIFIED FIXED

(support.mozilla.org :: Army of Awesome, task)

Description

[Kadir Topal [:atopal]]

Pressing the refresh button next to "choose a tweet to help" doesn't have any effect on the tweets shown in the area below.

Comment 1

[Fred Wenzel [:wenzel]]

"not any" is prehaps inaccurate -- it seems to update the list (the relative time stamps change). It's possible though that either the queryset it cached, or the cron job is not run frequently enough. Either way, I suggest we only show the refresh button when we are sufficiently confident there will be changed data available (after a minute has passed since the page load / last refresh click, maybe?).

Comment 2

[David Tenser [:djst]]

I think that sounds like a good solution to not show the refresh button immediately.

Another solution might be to indicate visually that the list has been refreshed. Right now it appears as if nothing happens. I don't know if it's simple to maybe blank out the list and fade in the list again when hitting the button?

Even the state of the Refresh button is completely unchanged (it could for e.g. disable during the update and then be enabled again when the list is refreshed).

Comment 3

[Kadir Topal [:atopal]]

Another option: We show page 2 of the list, and show page 1 when the user clicks on refresh. It might be that there is nothing interesting to reply to on that list + it gives the user more chances to interact with the site and freedom to choose 'their' tweet. A second click on refresh would then indicate that there are no new tweets.

Comment 4

[Alex Buchanan [:abuchanan]]

What if we show a message like "No new tweets found"?

Comment 5

[Kadir Topal [:atopal]]

The idea was not to disappoint people and give them more freedom to choose, but by no means let this be a blocker. As long as the refresh button gives any visual feedback in the tweets-area this bug can be closed.

Comment 6

[Alex Buchanan [:abuchanan]]

(In reply to comment #2)
> Another solution might be to indicate visually that the list has been
> refreshed. Right now it appears as if nothing happens. I don't know if it's
> simple to maybe blank out the list and fade in the list again when hitting the
> button?
> 
> Even the state of the Refresh button is completely unchanged (it could for e.g.
> disable during the update and then be enabled again when the list is
> refreshed).

Went with these.

http://github.com/jsocol/kitsune/commit/24afd8c3d63d8c3289b5e028683c4fc457bcf8be

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/en-US/army-of-awesome and https://master.support.mozilla.com/en-US/army-of-awesome