Closed Bug 601120 Opened 9 years ago Closed 9 years ago

[eo] searchplugin order regressed

Categories

(Mozilla Localizations :: eo / Esperanto, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

()

Details

(Keywords: productization)

http://hg.mozilla.org/l10n-central/eo/diff/de3816e459d7/browser/chrome/browser-region/region.properties regressed the searchplugin order to make yahoo the default browser.

Changes like this need to be reviewed before landing, if intended. And, well, shouldn't happen if not intended, of course.

I'll reject the sign-off on http://hg.mozilla.org/l10n-central/eo/pushloghtml?changeset=c45988f1bb1d based on this bug.

Side note, looking at the diff, https://l10n-stage-sj.mozilla.org/shipping/diff?tree=fx40x&locale=eo&from=c4393d309920&repo=l10n-central/eo&url=http://hg.mozilla.org/l10n-central/eo/&to=c45988f1bb1d, I found quite a few strings that went from translated back to English, that caught me by surprise. Less than from English to translated, but still. Might be worth looking into as well.
Sorry, it was not intended.  It was a (now fixed) problem with the translation tool that also reverted some strings.

I got region.properties from this revision:

Stas Malolepszy - Land siteSearchURL if needed. Bug 486719: Add localization note to region.properties about review from l10n drivers being required for any changes (part of mass-landing by stas)
http://hg.mozilla.org/l10n-central/eo/file/42204ca7f60f

And pushed it in:

http://hg.mozilla.org/l10n-central/eo/file/01f1c98d1a84

I hope this fixes it.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
I just noticed we are yellow because of keyword.URL in region.properties.

I read the following message but I don't understand if I can go ahead and remove the entity or not.

[ANNOUNCE] removal of keyword.URL on l10n-central's browser-region/region.properties
http://groups.google.de/group/mozilla.dev.l10n/browse_thread/thread/a1004883745e5ef3

What should I do?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Thanks.

for the keyword.URL, I had a blank approval/review in the newsgroup, feel free to remove that entity.

I've rejected the latest sign-off again, as it still had this bug in it, but a sign-off on a new revision should be fine, I guess.
Ok, so I guess that we can close this one now.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Thanks!
You need to log in before you can comment on or make changes to this bug.