601163 - "Clear Site Preferences: Password" appears in site menu on all sites when "Remember Passwords" is disabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

In today's Android nightly build, "Clear Site Preferences: Password" appears every time the site menu is opened on any page.

Comment 1

[Matt Brubeck (:mbrubeck)]

After moving prefs.js out of my profile, I am not seeing this bug anymore.  I saved the prefs.js file, and will try to figure out which pref caused the problem.

Comment 2

[Matt Brubeck (:mbrubeck)]

This happens whenever "Remember Passwords" (signon.rememberSignons) is disabled at startup.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

getLoginSavingEnabled always returns false when signon.rememberSignons is false.

There's one edge case this patch doesn't handle - the bug still appears if you flip the preference from "false" to "true" while Fennec is running.  The bug goes away once Fennec restarts.  (It seems the login service still returns false after this happens, even though it appears to have a preference observer that should prevent this.)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 480159 [details] [diff] [review]
patch

* Keep the {} on the outer "if"
* Add a comment as to why we need to check the pref, maybe a short one with a link to this bug

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> * Keep the {} on the outer "if"
> * Add a comment as to why we need to check the pref, maybe a short one with a
> link to this bug

Done and done.  Pushed:
http://hg.mozilla.org/mobile-browser/rev/33f11512d5cd

Comment 6

[Catalin Suciu [:csuciu]]

This issue is not reproducible on Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110912 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2