Do not display (show) when the CC list is empty

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
User Interface
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Frédéric Buclin, Assigned: Guy Pyrzak)

Tracking

Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +

Details

Attachments

(1 attachment)

v1
1.60 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
CC List:   	0 users  (show) 

For logged out users, the (show) link is displayed even when the CC list is empty. Clicking on it of course has no effect, besides making this link to disappear. It shouldn't be displayed at all in that case.
(Assignee)

Comment 1

8 years ago
Created attachment 480232 [details] [diff] [review]
v1
Assignee: ui → guy.pyrzak
Attachment #480232 - Flags: review?(LpSolit)
(Reporter)

Comment 2

8 years ago
Comment on attachment 480232 [details] [diff] [review]
v1

>+        [% UNLESS (NOT user.id) && NOT bug.cc.size %]

Write [% IF user.id || bug.cc.size %] instead. That's much more readable.


Otherwise looks good (I didn't test your patch). r=LpSolit with the condition changed at both places.
Attachment #480232 - Flags: review?(LpSolit) → review+
(Reporter)

Updated

8 years ago
Flags: approval4.0+
Flags: approval+
Target Milestone: --- → Bugzilla 4.0
(Assignee)

Comment 3

8 years ago
Committing to: bzr+ssh://guy.pyrzak%40gmail.com@bzr.mozilla.org/bugzilla/4.0/                                     
modified template/en/default/bug/edit.html.tmpl
Committed revision 7427.

Committing to: bzr+ssh://guy.pyrzak%40gmail.com@bzr.mozilla.org/bugzilla/trunk/                                   
modified template/en/default/bug/edit.html.tmpl
Committed revision 7510.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.