intermittent test-xpcshell failure: test_filepointer.js | test failed (with xpcshell return code: 0)

VERIFIED FIXED in mozilla2.0b7

Status

()

defect
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: Margaret, Assigned: mossop)

Tracking

({intermittent-failure})

Trunk
mozilla2.0b7
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

s: talos-r3-fed-036
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | 1.0 == 2.0 - See following stack:

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | test failed (with xpcshell return code: 0), see following log:
  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-INFO | (xpcshell/head.js) | test 2 pending
*** LOG addons.manager: Application has been upgraded
*** LOG addons.xpi: startup

 Skipping 138 Lines...

*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: Add-on addon1@tests.mozilla.org modified in app-profile
*** LOG addons.xpi: Updating database with changes to installed add-ons
*** LOG addons.xpi: Updating add-on states
*** LOG addons.xpi: Writing add-ons list
TEST-PASS | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | [anonymous : 289] [object Object] != null
TEST-PASS | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | [anonymous : 290] 2.0 == 2.0
*** LOG addons.xpi: shutdown
*** LOG addons.xpi: Updating add-on states
*** LOG addons.xpi: Writing add-ons list
*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: Processing uninstall of addon1@tests.mozilla.org in app-profile
*** LOG addons.xpi: Add-on addon1@tests.mozilla.org removed from undefined
*** LOG addons.xpi: No changes found
*** LOG addons.xpi: shutdown
*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: New add-on addon1@tests.mozilla.org installed in app-profile
*** LOG addons.xpi: Updating database with changes to installed add-ons
*** LOG addons.xpi: Updating add-on states
*** LOG addons.xpi: Writing add-ons list
TEST-PASS | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | [anonymous : 308] [object Object] != null
TEST-PASS | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | [anonymous : 309] 1.0 == 1.0
*** LOG addons.xpi: shutdown
*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: No changes found
TEST-PASS | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | [anonymous : 318] [object Object] != null
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js | 1.0 == 2.0 - See following stack:
JS frame :: /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/head.js :: do_throw :: line 317
JS frame :: /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/head.js :: do_check_eq :: line 347
JS frame :: /home/cltbld/talos-slave/mozilla-central_fedora_test-xpcshell/build/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell-unpack/test_filepointer.js :: anonymous :: line 319
JS frame :: resource://gre/modules/AddonManager.jsm :: safeCall :: line 45
JS frame :: resource://gre/modules/AddonManager.jsm :: anonymous :: line 676
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 2091
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 3609
JS frame :: resource://gre/modules/XPIProvider.jsm :: completeAddon :: line 2790
JS frame :: resource://gre/modules/AddonRepository.jsm :: anonymous :: line 438
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 2794
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 3481
JS frame :: resource://gre/modules/XPIProvider.jsm :: anonymous :: line 3480
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test
*** WARN addons.manager: Exception calling callback: 2147500036
*** LOG addons.xpi: shutdown

  <<<<<<<
I suppose it is possible here that if the test takes 3 seconds between a couple of parts then this could happen, probably want to decrement the original write
Posted patch patch rev 1Splinter Review
In two places in this test we do the following:

Write out an extension's files into a directory
Do some tests
Write out an extension again and decrease its modified time to be 5 second before the present
Check that the changes were detected.

If there is around 5 seconds (or even as low a 3 since FAT only has a 2 second resolution) between the two writes then the file modification won't get spotted. Instead this decreases the modification time of the first write guaranteeing that the modified times should change by at least 5 seconds.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #480226 - Flags: review?(robert.bugzilla)
Attachment #480226 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/96d1e0de6f7f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Version: unspecified → Trunk
No failure in the last month. Lets mark it as verified fixed.
Status: RESOLVED → VERIFIED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.