601242 - jetpack-core's "test-tab-browser.testEventsAndLengthStayInModule" depends on addon-kit's "tabs" module

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

In bug 596406 we moved the 'tabs' module into the addon-kit package, which itself depends on the jetpack-core package. However, the test suite for tab-browser--one of the modules in jetpack-core--imports 'tabs', which means there's a circular dependency between jetpack-core (or at least its test suite) and addon-kit.

The reason this doesn't crop up on 'cfx test' or continuous integration is because addon-kit is added to all cfx runs by default. To disable it, we need to explicitly tell cfx not to include it, which can be done by going into packages/jetpack-core and running 'cfx test --extra-packages='.

Comment 1

[Atul Varma [:atul]]

One easy but weird way out of this is to just move testEventsAndLengthStayInModule to be in the test suite for 'tabs' in addon-kit.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

It should be easy to remove this dependency. The tabs module is just an instantiation of tabBrowser.TabModule that doesn't track any specific window.

It currently uses the tabs module as there was no reason not to, and also it's the intended consumer of TabModule. But now that they're in different packages we can just replace require("tabs") here for new TabModule()

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 4

[Dietrich Ayala (:dietrich)]

Fixed by bug 613553.