Closed Bug 601307 Opened 14 years ago Closed 14 years ago

Add a test for |with (...) eval(...)| being direct

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

I momentarily twisted my brain into knots thinking this case was an indirect eval, and I'd like to make sure we don't somehow, sometime, end up breaking this:

  var t = "global";
  function test()
  {
    var t = "local";
    with ({})
      return eval("t");
  }
  assertEq(test(), "local");
Attached patch TestSplinter Review
Attachment #480350 - Flags: review?(jimb)
Attachment #480350 - Flags: review?(jimb) → review+
http://hg.mozilla.org/tracemonkey/rev/3a902a592341
Summary: Add a test for |with (global) eval(...)| being direct → Add a test for |with (...) eval(...)| being direct
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla2.0b8
http://hg.mozilla.org/mozilla-central/rev/3a902a592341
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.