Styling a tab's background with a custom color - draws it also around the tab

RESOLVED INCOMPLETE

Status

()

Firefox
Theme
RESOLVED INCOMPLETE
8 years ago
2 years ago

People

(Reporter: Please Ignore This Troll (Account Disabled), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101001 Firefox/4.0b7pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b7pre) Gecko/20101001 Firefox/4.0b7pre

Currently, styling the tabs is almost impossible.

Reproducible: Always

Steps to Reproduce:
Try applying styles like:
tab { background-color: green !important; }
or
tab { background: green !important; }
Actual Results:  
Paints tabs and space between and above tabs with green color.

Expected Results:  
Paints only tabs with green color. The space between them and above them shouldn't be affected by this style.

Another "who the hell cares?" bug.
I bet this won't get fixed in a 3 years.

Comment 1

8 years ago
If you would like this bug to be fixed, then please don't berate Mozilla folks. They do their best, and they have lots of time-critical crashes and new features to deal with. This sort of enhancement sometimes escapes their attention, because it is not a critical change.

Why do you want this capability? For themes? And where are you applying these CSS rules? In a theme, you can probably fix this by supplying your own tab image (like the one at chrome://browser/skin/tabbrowser/tab.png ) and applying the CSS rule "-moz-border-image: url("path/to/your/tab.png") 4 5 3 6 / 4px 5px 3px 6px ", with adjusted sizes at the end.
Component: Tabbed Browser → Theme
QA Contact: tabbed.browser → theme
(In reply to comment #1)
> If you would like this bug to be fixed, then please don't berate Mozilla folks.
> They do their best, and they have lots of time-critical crashes and new
> features to deal with. This sort of enhancement sometimes escapes their
> attention, because it is not a critical change.
> 
> Why do you want this capability? For themes? And where are you applying these
> CSS rules? In a theme, you can probably fix this by supplying your own tab
> image (like the one at chrome://browser/skin/tabbrowser/tab.png ) and applying
> the CSS rule "-moz-border-image: url("path/to/your/tab.png") 4 5 3 6 / 4px 5px
> 3px 6px ", with adjusted sizes at the end.

So in case I want to simply paint the active tab's background to pink - I will have to use a style like

{background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsIAAA7CARUoSoAAAAANSURBVBhXY1Da6PMfAAQ3Ah/zQJDzAAAAAElFTkSuQmCC") !important;
background-repeat: no-repeat !important;
background-position: -4px -3px !important; }

instead of a short style:

{background-color:pink !important; }

Do you see the difference?
+ Even if you don't use any styles - this bug sometimes appears for me: the space between tabs sometimes (only sometimes) becomes a color of tabs' background.
Severity: normal → major
Severity: major → normal

Comment 4

8 years ago
In other words, I take it this is for an extension of some kind.

In my view this is a wontfix. The firefox default theme's style is designed for the firefox default theme's colours. Other themes can and do provide their own tab.png images. Making allowances for special use cases (like this custom CSS) is not easy to do, and probably not worthwhile.

This kind of tab styling does not account for different themes, either. Some way to highlight tabs would need to be added as a core Firefox feature (using JS or interfaces, probably) for this to work.

I suggest you file that second issue as a separate bug. It sounds like a mainstream cosmetic issue.
(In reply to comment #4)
> In other words, I take it this is for an extension of some kind.

No. Just a userstyle for userchrome.css or stylish.

> In my view this is a wontfix. The firefox default theme's style is designed
> for the firefox default theme's colours. Other themes can and do provide
> their own tab.png images. Making allowances for special use cases (like this
> custom CSS) is not easy to do, and probably not worthwhile.

1. I'm not talking about default theme (though if you read Comment #3 you'll see that it is also affected), I'm talking about some mistakes in the attributes for some UI elements, which should be fixed.

2. This makes themes use hacks, which is not good (though it may look similar) and it makes the code of such themes way more complicated. Is firefox for users who want to customize their browser or for the users that have to invent hacks to fix firefox's problems?

> This kind of tab styling does not account for different themes, either. Some
> way to highlight tabs would need to be added as a core Firefox feature (using
> JS or interfaces, probably) for this to work.

****. There are enough of pure CSS functions to highlight whatever you want.

> I suggest you file that second issue as a separate bug. It sounds like a
> mainstream cosmetic issue.

Sorry, I don't get what you suggest me to file the 2nd bug about.
1 bug is enough for what I wanted to point at. I don't need more, so if you want - you are free to create it by yourself.
And yes, I agree that 90% that this bug will stay unconfirmed/ignored for years or will get a "WONTFIX" pretty soon, just as I said.
Developers do the work in a dirty way, and QA accept it in that state - that is the problem.
The bug can be fixed quite easily, by the way. With just changing some values in the CSS-style for default theme, but who the hell cares?
Once I was already told by one mozdev that they don't care about users, about their opinions, about the bugs they create (that seemed uninteresting for mozdevs). He even calls us, users, with the word "****" in his speeches. Beltzner let's him do that and all they can is to ban unwanted people (this is my 3rd acc in bugzilla, the previous ones were banned for no reason).
(In reply to comment #6)
> The bug can be fixed quite easily, by the way. With just changing some values
> in the CSS-style for default theme

https://developer.mozilla.org/en/Creating_a_patch
(In reply to comment #7)
> (In reply to comment #6)
> > The bug can be fixed quite easily, by the way. With just changing some values
> > in the CSS-style for default theme
> 
> https://developer.mozilla.org/en/Creating_a_patch

Those articles are overburdened with information. I won't take my time read them all. All I need is a 1 page step-by-step guide describing the process of creating diff file (without downloading Hg and with an ability to download only the specified files, not all the files of the base).
Or create a page where a user can specify which file to modify, which lines of code to modify in it and just a textarea where a user can write in the code he offers, then he just clicks a button "forge diff-file" and gets a link to it.

If you want people to help you creating patches - you have to make the process easier.
Or make patches yourself.
Or ignore bugs, like you get used to.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.