Closed
Bug 601358
Opened 14 years ago
Closed 14 years ago
d3d10 compilation failure without d2d compilation enabled
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
574 bytes,
patch
|
bas.schouten
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
D3D10 layers code assumes that d2d support is enabled, so disabling d2d should imply disabled d3d10.
Assignee | ||
Updated•14 years ago
|
Attachment #480388 -
Attachment is patch: true
Attachment #480388 -
Flags: review?(bas.schouten)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → jacek
Comment 1•14 years ago
|
||
(In reply to comment #0) > Created attachment 480388 [details] [diff] [review] > fix v1.0 > > D3D10 layers code assumes that d2d support is enabled, so disabling d2d should > imply disabled d3d10. I'm okay with this I think.. But why would D2D be disabled and D3D10 be available?
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > I'm okay with this I think.. But why would D2D be disabled and D3D10 be > available? Generally, it's because of --with-windows-version= configure option that sets explicitly not to use newer APIs and if set to something less than 610, d2d is disabled although headers may be available. In my case I use it to compile on mingw, because mingw's headers are not yet good enough to build all win7 features, although some parts like d3d10 are available.
Comment 3•14 years ago
|
||
Comment on attachment 480388 [details] [diff] [review] fix v1.0 [Checked in: See comment 8] OK, sorry, I didn't know that was an existing build configuration.
Attachment #480388 -
Flags: review?(bas.schouten) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #480388 -
Flags: approval2.0?
Assignee | ||
Comment 4•14 years ago
|
||
Thanks for quick review.
Updated•14 years ago
|
Component: GFX: Color Management → Graphics
QA Contact: color-management → thebes
Comment 5•14 years ago
|
||
Comment on attachment 480388 [details] [diff] [review] fix v1.0 [Checked in: See comment 8] This is approved for checkin *after* beta 7.
Attachment #480388 -
Flags: approval2.0? → approval2.0+
Comment 7•14 years ago
|
||
(In reply to comment #6) > *** Bug 603532 has been marked as a duplicate of this bug. *** Damn: this patch was approved to land a week before I lost my time on this issue! Could you land my patch (for its added comment...) there with the approval here asap? Thanks.
Status: NEW → ASSIGNED
Flags: in-testsuite-
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #7) > (In reply to comment #6) > > *** Bug 603532 has been marked as a duplicate of this bug. *** > > Damn: this patch was approved to land a week before I lost my time on this > issue! Yeah, it was waiting for b6 back then... > Could you land my patch (for its added comment...) there with the approval here > asap? http://hg.mozilla.org/mozilla-central/rev/a6e70b28834f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Attachment #480388 -
Attachment description: fix v1.0 → fix v1.0
[Checked in: See comment 8]
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•