601447 - "Remove All Shown" deletes all logins (passwords) when filtered without results.

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[Aaron Whitehouse]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.10) Gecko/20100915 Ubuntu/10.04 (lucid) Firefox/3.6.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.10) Gecko/20100915 Ubuntu/10.04 (lucid) Firefox/3.6.10

I had multiple passwords for Facebook, some of which were not correct. I opened the Saved Passwords screen and filtered to show "facebook" passwords. I then clicked "Remove All". It removed all of my saved passwords instead of just those listed.

Reproducible: Always

Steps to Reproduce:
1. Open "Saved Passwords".
2. Filter by something.
3. Click "Remove All".
4. Confirm.
Actual Results:  
All passwords are deleted.

Expected Results:  
That Firefox would only delete those passwords shown.

I do realise that the confirm box warns that all passwords will be deleted, but it caught me and I consider myself quite an experienced user.

Comment 2

[Matthew N. [:MattN]]

Only the visible passwords are deleted but the dialog thinks they were all deleted. If you re-open the dialog, the logins that didn't match the filter will still be there.

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Build ID 	20160126030244
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.0

Hi,

I have investigated this issue and I have found 2 scenarios:

#1
Steps to reproduce:
1. Have multiple saved logins.
2. Go to about:config#security and click on "Saved Logins...".
3. Enter a search term that returns 2 or 3 items(in my case I searched for google and had 3 different Google accounts listed).
4. Without selecting anything click "Remove All" and confirm the removal.
5. Clear the Search field.

Actual results:
4. The filtered logins are removed. 
5. All logins are displayed, except the ones removed at step 4.

#2
Steps to reproduce:
1. Have multiple saved logins.
2. Go to about:config#security and click on "Saved Logins...".
3. Enter a search term that returns no items, for example a symbol.
4. Click the "Remove All" button and confirm the removal.
5. Clear the Search field.

Actual results:
3. After the search is performed, there are no entries displayed.
4. "Remove All" button is active. After clicking on it, the remove all dialog is displayed.
5. No entries are displayed because they were removed at step 4.

Based on the 2 scenarios presented above what should be the expected result?
* Should the "Remove All" button remove all Saved Logins regardless of searched terms?
* Should the "Remove All" button only remove the searched entries?

Thanks,
Cipri

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to Ciprian Muresan [:cmuresan] from comment #4)
> Based on the 2 scenarios presented above what should be the expected result?
> * Should the "Remove All" button remove all Saved Logins regardless of
> searched terms?
> * Should the "Remove All" button only remove the searched entries?
> 
> Thanks,
> Cipri

Possibly neither. It seems to me, to avoid confusion:
1. "remove" should be changed to "remove selected"
2. "remove all" should be disabled if any items are selected

Comment 7

[Hartmut Welpmann [:welpy-cw]]

(In reply to Ciprian Muresan [:cmuresan], Ecosystem QA from comment #4)

I have investigated this issue and I have found 2 scenarios:

#1
Steps to reproduce:

1. Have multiple saved logins.
2. Go to about:config#security and click on "Saved Logins...".
3. Enter a search term that returns 2 or 3 items(in my case I searched for
   google and had 3 different Google accounts listed).
4. Without selecting anything click "Remove All" and confirm the removal.

This has since been renamed to "Remove All Shown" in this case.

5. Clear the Search field.

Actual results:
4. The filtered logins are removed.
5. All logins are displayed, except the ones removed at step 4.

So I think scenario #1 is okay.

#2
Steps to reproduce:

1. Have multiple saved logins.
2. Go to about:config#security and click on "Saved Logins...".
3. Enter a search term that returns no items, for example a symbol.
4. Click the "Remove All" button and confirm the removal.

Since this is being displayed as "Remove All Shown" in this case as well …

5. Clear the Search field.

Actual results:
3. After the search is performed, there are no entries displayed.
4. "Remove All" button is active. After clicking on it, the remove all
dialog is displayed.
5. No entries are displayed because they were removed at step 4.

… this is an unexpected outcome, to say the least. The "Remove All Shown" button should definitely be disabled if there aren't any entries shown.

Comment 8

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 601447 - Disable "Remove All Shown" logins when filtered without results. r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3546109a8cde
Disable "Remove All Shown" logins when filtered without results. r=mkmelin

Comment 10

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9427049 [details]
Bug 601447 - Disable "Remove All Shown" logins when filtered without results. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1338036
User impact if declined: loss of all saved passwords
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): none

Comment 11

[Corey Bryant]

Comment on attachment 9427049 [details]
Bug 601447 - Disable "Remove All Shown" logins when filtered without results. r=mkmelin

[Triage Comment]
Richard, are both patches needed to fix this?

Comment 12

[Richard Marti (:Paenglab)]

Are you asking in the wrong bug? I had nothing done in this bug.

Comment 13

[Corey Bryant]

(In reply to Richard Marti (:Paenglab) from comment #12)

Are you asking in the wrong bug? I had nothing done in this bug.

Must be! Sorry..

Comment 14

[Corey Bryant]

Comment on attachment 9427049 [details]
Bug 601447 - Disable "Remove All Shown" logins when filtered without results. r=mkmelin

[Triage Comment]
Approved for esr128

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 128.3.3esr:
https://hg.mozilla.org/releases/comm-esr128/rev/8c8e23b96f26