601456 - Sync UI: "I have lost my Sync Key" should clear Weave.Service.passphrase

Status: RESOLVED DUPLICATE of bug 630885

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

When signing up a computer to an existing account, if you get the Sync Key wrong, you're given the option to change it. But it's impossible to change it to the Sync Key that you just tried to log in with because that has been stored in Weave.Service.passphrase and the UI now thinks that's your existing Sync Key ("The new Sync Key cannot be the same as your Sync Key").

Comment 1

[Philipp von Weitershausen [:philikon]]

Note that with bug 603489 or in the aftermath thereof we're removing the ability to provide a custom Sync Key, rendering this bug obsolete.

Comment 2

[Philipp von Weitershausen [:philikon]]

This bug isn't quite as obsolete as I hoped it would be. It's true that with new crypto we no longer allow custom Sync Keys, but the bug remains. It's even slightly more annoying now because we now always show a link for a resetting your Sync Key which will display "undefined" if you haven't entered anything yet.

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> This bug isn't quite as obsolete as I hoped it would be. It's true that with
> new crypto we no longer allow custom Sync Keys, but the bug remains. It's even
> slightly more annoying now because we now always show a link for a resetting
> your Sync Key which will display "undefined" if you haven't entered anything
> yet.

Worse even, the dialog doesn't work properly. Fwd-duping this to bug 630885 which fixes this.