601471 - Unify: stop trying to 'package-tests' builds with '--disable-tests'

Status: VERIFIED FIXED

(MailNews Core :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Sunbird/1286077550.1286078440.21655.gz&fulltext=1
MacOSX 10.5 comm-central lightning build on 2010/10/02 20:45:50
{
ac_add_options --disable-tests

make -f client.mk build
...
/builds/buildbot/comm-central-lightning-macosx/build/mozilla/build/macosx/universal/unify \
	    --unify-with-sort "\.manifest$" \
	    --unify-with-sort "components\.list$" \
	    objdir-tb/ppc/mozilla/dist/thunderbird/Shredder.app \
	    objdir-tb/i386/mozilla/dist/thunderbird/Shredder.app \
	    objdir-tb/ppc/mozilla/dist/universal/thunderbird/Shredder.app
make -C objdir-tb/ppc UNIVERSAL_BINARY= CHROME_JAR= package-tests
make[2]: *** No rule to make target `package-tests'.  Stop.
make[1]: *** [postflight_all] Error 2
make: *** [build] Error 2
}

This affects (Opt) Calendar builds only, as FF/SM/TB builds with '--enable-tests'.

Comment 1

[Serge Gautherie (:sgautherie)]

PS: You might want to do it in mozilla-central first/too.

Comment 3

[Stefan Sitter [:ssitter]]

Is there a workaround? The macosx calendars builds are failing since 4 weeks.

Comment 4

[Mark Banner (:standard8)]

Pushed a fix that'll hopefully fix this:

http://hg.mozilla.org/comm-central/rev/67033a790980

(with rs=Callek over irc).

Comment 5

[Mark Banner (:standard8)]

That worked, I've queued up a Mac nightly as well.

Comment 6

[Serge Gautherie (:sgautherie)]

V.Fixed, per
http://build.mozillamessaging.com/tinderboxpushlog/?tree=Sunbird