601599 - about:memory crashes Fennec on Samsung Galaxy S

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Steffen Wilberg]

Using the latest nightly, about:memory crashes Fennec on my Samsung Galaxy S.

If I enter about:memory manually, I can see the page briefly before Fennec crashes.
If I click the link on about:about to about:memory, the crash is almost instant.

Comment 1

[Aakash Desai [:aakashd]]

Is this happening to you too, Matt?

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Wait, is this only happening on galaxy s devices?  (I repro'd on one, but it looks like a general problem.)

(gdb) bt
#0  0x830000b4 in ?? ()
#1  0x8395b9ec in getMallocMapped (this=<value optimized out>, memoryUsed=0x4cd668d8) at /home/cjones/mozilla/mozilla-central/xpcom/base/nsMemoryReporterManager.cpp:78
#2  MemoryReporter_MallocMapped::GetMemoryUsed (this=<value optimized out>, memoryUsed=0x4cd668d8) at /home/cjones/mozilla/mozilla-central/xpcom/base/nsMemoryReporterManager.cpp:136
#3  0x8395becc in NS_InvokeByIndex_P (that=0x4c704388, methodIndex=<value optimized out>, paramCount=<value optimized out>, params=<value optimized out>) at /home/cjones/mozilla/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:190
#4  0x836e95b8 in Invoke (ccx=<value optimized out>, mode=<value optimized out>) at /home/cjones/mozilla/mozilla-central/js/src/xpconnect/src/xpcwrappednative.cpp:3054
#5  Call (ccx=<value optimized out>, mode=<value optimized out>) at /home/cjones/mozilla/mozilla-central/js/src/xpconnect/src/xpcwrappednative.cpp:2321
#6  XPCWrappedNative::CallMethod (ccx=<value optimized out>, mode=<value optimized out>) at /home/cjones/mozilla/mozilla-central/js/src/xpconnect/src/xpcwrappednative.cpp:2285

(gdb) printf "%s", PrintJSStack()
0 updateMemoryStatus() ["chrome://global/content/aboutMemory.js":128]
    row = undefined
    rep = undefined
    otherCount = undefined
    mo = undefined
    this = [object Window]
1 doLoad() ["chrome://global/content/aboutMemory.js":169]
    mr = [xpconnect wrapped nsIMemoryReporter]
    e = [xpconnect wrapped nsISimpleEnumerator]
    mgr = [xpconnect wrapped nsIMemoryReporterManager]
    this = [object Window]
2 onload(event = [object Event]) ["about:memory":1]
    this = [object Window]

On "normal" linuxes, we play linker tricks to get at jemalloc_stats() at runtime.  The setup on android is totally different, and we use a different dynamic linker to boot.  I think we should just disable this code for the time being.  There's probably a better strategy for android anyway, since jemalloc is more pervasive there.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Link directly to jemalloc_stats on android

No need to go through the __attribute__((weak)) indirection since libxul already links to jemalloc.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Hm, actually I can believe that this was an i9000-only crash.  nm.  Bad samsung.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/7adf04164a43