Closed
Bug 601677
Opened 15 years ago
Closed 15 years ago
pymake should support -n/--just-print
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file, 1 obsolete file)
|
13.08 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #480680 -
Flags: review?(ted.mielczarek)
|
||
Updated•15 years ago
|
Assignee: nobody → jorendorff
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 480680 [details] [diff] [review]
v1
Does this handle native commands correctly? (process.py is a bit difficult to read even with lots of context.)
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 480680 [details] [diff] [review]
v1
Guess not. You'll need to make the same changes to call_native and friends. khuey updated the pymake in mozilla-central, or you can work against bsmedberg's user repo.
Attachment #480680 -
Flags: review?(ted.mielczarek) → review-
|
Assignee | |
Comment 3•15 years ago
|
||
With tests, even!
Attachment #480680 -
Attachment is obsolete: true
Attachment #485077 -
Flags: review?(ted.mielczarek)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 485077 [details] [diff] [review]
v2
Looks good, and nice cleanup/refactoring!
Attachment #485077 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•