601739 - aEntry.children.forEach is not a function error stops session from updating

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

There have been a few reports going around of session restore restoring an old session. My theory has always been that something goes wrong a period of time before quitting, but we've never caught one with the problem before quitting... until now

http://hg.mozilla.org/mozilla-central/annotate/91a49bf6464b/browser/components/sessionstore/src/nsSessionStore.js#l1885 is at blame here. I'm not sure how we would get into a state where children isn't an array. That could be the problem or it could be coming from somewhere deeper in the platform (not entirely likely since this is looking at data we set up ourselves).

Comment 1

[David Teller [:Yoric] - still alive but not very active]

This code has been entirely rewritten a long time ago. This specific error shouldn't surface anymore.