Closed Bug 601748 Opened 14 years ago Closed 14 years ago

incrementalValidation busted

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 602489

People

(Reporter: treilly, Assigned: treilly)

References

Details

Attachments

(1 file)

IsWhite wrong and some userpointers being passed to realptr funcs.
Attached patch fix problemsSplinter Review
Attachment #480739 - Flags: review?
Attachment #480739 - Flags: superreview?(lhansen)
Attachment #480739 - Flags: review?(fklockii)
Attachment #480739 - Flags: review?
Assignee: nobody → treilly
OS: Windows XP → All
Hardware: x86 → All
Blocks: 601944
Status: NEW → ASSIGNED
Comment on attachment 480739 [details] [diff] [review]
fix problems

General comments:

- if we never used variable names like 'item' but always used 'realptr'
  and 'userptr', there would be a lower risk of this happening.

- if we avoided terms 'White', 'Grey', 'Black' but instead used terms like
  Unmarked, BeingMarked, Marked (not necessarily perfect), there would be
  a lower risk of this happening.  I always get White and Black mixed up.
Attachment #480739 - Flags: superreview?(lhansen) → superreview+
Comment on attachment 480739 [details] [diff] [review]
fix problems

I used to get confused by the White/Gray/Black stuff.  At this point I internalized it as "Unmarked/MarkFrontier/Marked"; I don't know if the "frontier" terminology helps others more than just "BeingMarked" ...
Attachment #480739 - Flags: review?(fklockii) → review+
(In reply to comment #5)
> Comment on attachment 480739 [details] [diff] [review]
> fix problems
> 
> I used to get confused by the White/Gray/Black stuff.  At this point I
> internalized it as "Unmarked/MarkFrontier/Marked"; I don't know if the
> "frontier" terminology helps others more than just "BeingMarked" ...

It might - if that were the terminology.  (Gray is easy to remember in any case.)
(In reply to comment #4)
> Unmarked, BeingMarked, Marked

+1
I'll change if(IsWhite to if(!IsMarkedOrQueued
Closing this bug, expanding scope into bug: 602489
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
bulk verifying resolved !fixed issues
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: