601851 - Switch progress line to slideback / cylon state on navigation event

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Right now we only switch to use the slideback CSS style created in bug 596812 when we get a "Connecting..." pause from the system. This results in a lack of immediate feedback after a user clicks on a navigation event. We should switch to the state immediately after we click, and switch to a loading progress bar once we start to show content.

Comment 1

[:Margaret Leibovic]

Attachment: patch

The issue seems to be that the css transition wasn't switching between different states until the first transitionend event (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#957), but setting the slideback attribute when we first show the progressmeter fixes that.

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 481067 [details] [diff] [review]
patch

Does this kick the animation off while statusMeter is collapsed?

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Please note that we have now created a branch for beta 7 work. In addition to landing your fix on mozilla-central default, please also land it on mozilla-central GECKO20b7pre_20101006_RELBRANCH

(note: when landing on mozilla-central default, you will be given priority in the landing queue at https://wiki.mozilla.org/LandingQueue )

Comment 4

[:Margaret Leibovic]

(In reply to comment #2)
> Comment on attachment 481067 [details] [diff] [review]
> patch
> 
> Does this kick the animation off while statusMeter is collapsed?

Yes, it does, but the statusMeter will be un-collapsed in the following else statement (looking through the code path, it looks like this._progressCollapseTimer will only be true if the statusMeter isn't collapsed).

I decided to put the line where I did because I figured it made sense to kick off the animation as soon as the value of the statusMeter was set to 0, since it may already be showing when that happens. However, I can move the new line down lower if you think that's better.

Comment 5

[Dão Gottwald [:dao]]

With your current patch the blob would become visible when it's somewhere in the middle, wouldn't it? So I think moving it down might be better.

Comment 6

[:Margaret Leibovic]

Attachment: patch v2

I moved the line. This patch is going to make bug 602126 worse, though, so I guess we need to see what happens there before this lands.

Comment 7

[:Margaret Leibovic]

Bug 602964 makes this invalid.