Closed Bug 601863 Opened 12 years ago Closed 12 years ago

Ensure all text strings are in dtd or properties file

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(blocking2.0 beta7+)

RESOLVED FIXED
Firefox 4.0b7
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: raymondlee, Assigned: raymondlee)

Details

(Whiteboard: [strings][qa-])

Attachments

(1 file)

See summary

e.g. in _createUndoButton() in groupitems.js
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attached patch v1Splinter Review
Attachment #480853 - Flags: feedback?(ian)
(In reply to comment #1)
> Created attachment 480853 [details] [diff] [review]
> v1
I've gone through panorama files and this is the only thing we need to update.
Attachment #480853 - Attachment is patch: true
Attachment #480853 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 480853 [details] [diff] [review]
v1

Good catch!

Do we need to make this beta7+ so it gets in before the string freeze?
Attachment #480853 - Flags: review?(dietrich)
Attachment #480853 - Flags: feedback?(ian)
Attachment #480853 - Flags: feedback+
blocking2.0: --- → ?
Attachment #480853 - Flags: review?(dietrich) → review+
Blocking b7+ on strings.
blocking2.0: ? → beta7+
Keywords: checkin-needed
Whiteboard: [strings]
Whiteboard: [strings] → [strings][has patch, can land]
https://hg.mozilla.org/mozilla-central/rev/beb044c602a7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [strings][has patch, can land] → [strings]
Target Milestone: --- → Firefox 4.0b7
Whiteboard: [strings] → [strings][qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.