test-masters.sh fail testing preproduction configs

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 480865 [details] [diff] [review]
Remove talos_masters redefinitions

e.g:
preprod-scheduler_master... Traceback (most recent call last):
  File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.5/site-packages/buildbot-0.8.1-py2.5.egg/buildbot/scripts/runner.py", line 995, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.5/site-packages/buildbot-0.8.1-py2.5.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/builds/buildbot/preproduction/slave/test-masters/sandbox/lib/python2.5/site-packages/buildbot-0.8.1-py2.5.egg/buildbot/master.py", line 572, in loadConfig
    exec f in localDict
  File "/builds/buildbot/preproduction/slave/test-masters/buildbot-configs/master_dir/master.cfg", line 4, in <module>
    import config
  File "/builds/buildbot/preproduction/slave/test-masters/buildbot-configs/master_dir/config.py", line 649, in <module>
    BRANCHES[branch]['platforms'][platform][key] = value
KeyError: 'macosx'
Broken pieces are in master_dir

talos_masters already defined as [] globally, so there is no need to redefine it to the same value for the particular platforms for try. See attached patch.
Attachment #480865 - Flags: review?(lsblakk)
Comment on attachment 480865 [details] [diff] [review]
Remove talos_masters redefinitions

Looks good.
Attachment #480865 - Flags: review?(lsblakk) → review+
Comment on attachment 480865 [details] [diff] [review]
Remove talos_masters redefinitions

http://hg.mozilla.org/build/buildbot-configs/rev/e07f108c580c
Attachment #480865 - Flags: checked-in+
Pre-production test passed:
http://preproduction-master.build.mozilla.org:8710/builders/test-masters/builds/502
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.