Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: Brent Baker, Unassigned)

Tracking

unspecified
Bug Flags:
flashplayer-qrb +
flashplayer-bug -
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
There are some changes that should be made to the build configuration that individually do not warrant their own bugs but need to be tracked and reviewed before being pushed.

This bug will be used for 'simple' changes to the build system.
Flags: flashplayer-triage+
(Reporter)

Comment 1

7 years ago
Created attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

Should clean up the repo at the end of the test phase so that the next build can start compiling faster since the previous repo should already be removed. We still need to start the build calling "sync_clean" in the event that the previous build failed.
Attachment #480927 - Flags: review?(jsudduth)
(Reporter)

Comment 2

7 years ago
Created attachment 480928 [details] [diff] [review]
Remove the unnecessary "sb_" prefix from the sandbox config

This patch should be applied after Attachment #480927 [details] [diff] 

This will make it much easier to transfer build step information between tamarinredux.py and sandbox.py
Attachment #480928 - Flags: review?(jsudduth)

Comment 3

7 years ago
Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

In tamarin-redux.py for the windows_64_test_builder the sync_clean call comes before the util_clean_buildsdir call. Other than that patch 480927 looks good.
Attachment #480927 - Flags: review?(jsudduth) → review-

Updated

7 years ago
Attachment #480928 - Flags: review?(jsudduth) → review+
(Reporter)

Comment 4

7 years ago
Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

patch pushed as 5323:a837d40687b9, with windows64 sync_clean at the end of the build
(Reporter)

Comment 5

7 years ago
Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

Marking patch as obsolete since it has been pushed (rev 5323:a837d40687b9). Normally I will not do this, but I want it to be clear which patches on this bug are still up for consideration of being pushed into the repo
Attachment #480927 - Attachment is obsolete: true

Comment 6

7 years ago
Do we still need this bug?

Updated

7 years ago
Flags: flashplayer-bug-

Comment 7

6 years ago
Appears closed or abandoned.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: flashplayer-qrb+
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.