601936 - Buildbot bucket bug

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Brent Baker]

There are some changes that should be made to the build configuration that individually do not warrant their own bugs but need to be tracked and reviewed before being pushed.

This bug will be used for 'simple' changes to the build system.

Comment 1

[Brent Baker]

Attachment: Remove the repo at the end of the "test" phase

Should clean up the repo at the end of the test phase so that the next build can start compiling faster since the previous repo should already be removed. We still need to start the build calling "sync_clean" in the event that the previous build failed.

Comment 2

[Brent Baker]

Attachment: Remove the unnecessary "sb_" prefix from the sandbox config

This patch should be applied after Attachment #480927 [details] [diff] 

This will make it much easier to transfer build step information between tamarinredux.py and sandbox.py

Comment 3

[James Sudduth]

Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

In tamarin-redux.py for the windows_64_test_builder the sync_clean call comes before the util_clean_buildsdir call. Other than that patch 480927 looks good.

Comment 4

[Brent Baker]

Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

patch pushed as 5323:a837d40687b9, with windows64 sync_clean at the end of the build

Comment 5

[Brent Baker]

Comment on attachment 480927 [details] [diff] [review]
Remove the repo at the end of the "test" phase

Marking patch as obsolete since it has been pushed (rev 5323:a837d40687b9). Normally I will not do this, but I want it to be clear which patches on this bug are still up for consideration of being pushed into the repo

Comment 6

[Trevor Baker]

Do we still need this bug?

Comment 7

[Dan Smith]

Appears closed or abandoned.