Closed Bug 601973 Opened 12 years ago Closed 12 years ago

SyncEngine._testDecrypt() yields wrong results

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Bug 600995 introduced a small bug in SyncEngine._testDecrypt() -- the wrong 'this' object is used.

This causes two crossweage tests to fail:
http://brasstacks.mozilla.com/resultserv/crossweave/testrun/31155/
Attached patch v1Splinter Review
Fix a 'this' scoping error in SyncEngine._testDecrypt(). Rename this method to canDecrypt() since it's clearly public API.

Provide tests for SyncEngine.canDecrypt() as well as Service.wipeClient().
Assignee: nobody → philipp
Attachment #480975 - Flags: review?(mconnor)
Attachment #480975 - Flags: review?(mconnor) → review+
blocking2.0: --- → beta7+
Pushed to fx-sync http://hg.mozilla.org/services/fx-sync/rev/57142f068ebd
Keeping this open until I land this on m-c.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to comment #2)
> Keeping this open until I land this on m-c.

And of course I did resolve it... force of habit. Keeping it resolved then.
Whiteboard: [qa-]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.