602029 - Hebrew Thunderbird 3.1 start page doesn't look well because of the product logo

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

As you can see on Hebrew Thunderbird 3.1 start page [1], The text is above the product logo, and this is not something we should expect to see there. Please move the content area to the left, so the logo will sit correctly on its spot. 

We have done similar tweak on Tb 3.0 start page [2], we may need to do the same for 3.1 as well. 

[1] http://www.mozillamessaging.com/he/thunderbird/3.1/start/
[2] http://www.mozillamessaging.com/he/thunderbird/3.0/start/

Comment 1

[Pascal Chevrel:pascalc]

fixed in r75288 (3.0 fix ported to 3.1), thanks for reporting :)
https://trunk.mozillamessaging.com/he/thunderbird/3.1/start/

Comment 2

[dror3go]

Pascal, Can we make another change in this page? The UL doesn't look so good, this should fix it:

html[dir=rtl] ul li {
  background-position: 100% 12px;
  padding: 2px 10px 4px 0;
}

Comment 3

[dror3go]

Even better - why don't we use here list-style-image instead of a background-image?

ul li {
  list-style-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAMAAAADCAMAAABh9kWNAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFaWRbAAAA+iK+cwAAAA5JREFUeNpiYEAAgAADAAAMAAFkFId7AAAAAElFTkSuQmCC);
  padding: 2px 0 4px 10px;
}
html[dir=rtl] ul li {
  padding: 2px 10px 4px 0;
}

Comment 4

[Pascal Chevrel:pascalc]

I used your first suggestion in r75325

Comment 5

[Tomer Cohen :tomer]

(In reply to comment #3)
> Even better - why don't we use here list-style-image instead of a
> background-image?

I don't think it is matter right now, but for the next time please consider using the list-style-image, as it will require less hacking for RTL-compatibility...

Comment 6

[dror3go]

(In reply to comment #5)
> I don't think it is matter right now, but for the next time please consider
> using the list-style-image, as it will require less hacking for
> RTL-compatibility...

It's not just about hacking for RTL-compatibility. Using list-style is the right thing to do for lists. using background-image instead is a hack, an unnecessary one. list-style is semantic.

Comment 7

[Tomer Cohen :tomer]

Dror, I agree with you, but please remember that the designers not always think well on RTL aspects of every element. list-style-image indeed is the right way of doing so.

As for semantic, I'm not sure if stylesheets are a factor for semantics. Semantic created by well formatted HTML, and has nothing to do with CSS.