Don't do metadata pings for mobile

VERIFIED FIXED

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mossop, Assigned: mfinkle)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
To avoid bandwidth usage, mobile doesn't need this additional metadata.
(Reporter)

Updated

7 years ago
Blocks: 602070
(Reporter)

Comment 1

7 years ago
Bug 584348 added the pref extensions.getAddons.cache.enabled which will cause additional metadata retrievals on mobile. I don't believe it is necessary for Fennec right now though, what do you think Mark?
(In reply to comment #1)
> Bug 584348 added the pref extensions.getAddons.cache.enabled which will cause
> additional metadata retrievals on mobile. I don't believe it is necessary for
> Fennec right now though, what do you think Mark?

Looks like we wouldn't need this. I thought it meant something different and also fell into the "do what Fx does" trap :)

Thanks, making a simple patch.
Created attachment 481302 [details] [diff] [review]
patch

The patch sets the pref explicitly to false instead of removing it, just so we remember.
Assignee: nobody → mark.finkle
Attachment #481302 - Flags: review?(dtownsend)
(Reporter)

Updated

7 years ago
Attachment #481302 - Flags: review?(dtownsend) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/5807503f22d8
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Aakash, could you please test the fix with one of the upcoming nighly builds for mobile? thanks!
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101011 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101011 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.