Closed Bug 602088 Opened 9 years ago Closed 9 years ago

after JS_New of a scripted constructor without a return value asserts

Categories

(Core :: JavaScript Engine, defect, P1, critical)

1.9.2 Branch
x86
macOS
defect

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: gal, Assigned: dvander)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

dvander has the details. This breaks the compartment patch queue.
blocking2.0: --- → ?
Assignee: general → dvander
Severity: normal → critical
Priority: -- → P1
This is blocking b7 and compartments landing.
Attached patch fixSplinter Review
The constructor threw an exception so rval wasn't *really* set. The assert wasn't checking the error state.

I don't know why this didn't show up before, it might be that the compartments patch queue caused the exception to appear or something.
Attachment #481271 - Flags: review?(lw)
Attachment #481271 - Flags: review?(lw) → review+
http://hg.mozilla.org/mozilla-central/rev/39bd6bc1bdd6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
blocking2.0: ? → betaN+
You need to log in before you can comment on or make changes to this bug.