after JS_New of a scripted constructor without a return value asserts

RESOLVED FIXED

Status

()

P1
critical
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: gal, Assigned: dvander)

Tracking

1.9.2 Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
dvander has the details. This breaks the compartment patch queue.
(Reporter)

Updated

8 years ago
blocking2.0: --- → ?
(Reporter)

Updated

8 years ago
Assignee: general → dvander
(Reporter)

Updated

8 years ago
Severity: normal → critical
Priority: -- → P1
(Reporter)

Comment 1

8 years ago
This is blocking b7 and compartments landing.
Created attachment 481271 [details] [diff] [review]
fix

The constructor threw an exception so rval wasn't *really* set. The assert wasn't checking the error state.

I don't know why this didn't show up before, it might be that the compartments patch queue caused the exception to appear or something.
Attachment #481271 - Flags: review?(lw)

Updated

8 years ago
Attachment #481271 - Flags: review?(lw) → review+

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/39bd6bc1bdd6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
blocking2.0: ? → betaN+
You need to log in before you can comment on or make changes to this bug.