Closed
Bug 602088
Opened 14 years ago
Closed 14 years ago
after JS_New of a scripted constructor without a return value asserts
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: gal, Assigned: dvander)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
914 bytes,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
dvander has the details. This breaks the compartment patch queue.
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Reporter | ||
Updated•14 years ago
|
Assignee: general → dvander
Reporter | ||
Updated•14 years ago
|
Severity: normal → critical
Priority: -- → P1
Reporter | ||
Comment 1•14 years ago
|
||
This is blocking b7 and compartments landing.
Assignee | ||
Comment 2•14 years ago
|
||
The constructor threw an exception so rval wasn't *really* set. The assert wasn't checking the error state. I don't know why this didn't show up before, it might be that the compartments patch queue caused the exception to appear or something.
Attachment #481271 -
Flags: review?(lw)
Updated•14 years ago
|
Attachment #481271 -
Flags: review?(lw) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/39bd6bc1bdd6
Whiteboard: fixed-in-tracemonkey
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/39bd6bc1bdd6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
blocking2.0: ? → betaN+
You need to log in
before you can comment on or make changes to this bug.
Description
•