602108 - Image document displays broken icon when canceling load

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Bobby Holley (:bholley)]

Steps to reproduce:

1-Load a big image as a file:
http://farm1.static.flickr.com/159/345009210_1f826cd5a1_o.jpg
2-Press escape before the image is done loading

The weird thing is that this works when the image is just referenced in the page (that was bug 565773). There must be something going on related to nsImageDocument that's screwing us up here.

Nominating so joe can decide if this blocks.

Comment 2

[Joe Drew (not getting mail)]

I would ship with this, but I'd *love* a fix too. :)

Comment 3

[Bobby Holley (:bholley)]

I'll have my hands full with XPConnect and js-ctypes for the foreseeable future - resetting assignee to default.

Comment 5

[Jesse Ruderman]

Also happens if I stop loading an animated GIF (even if the first frame is complete).

http://i.imgur.com/GnDbdge.gif

Comment 6

[[e-mail]]

When you cancel a load it cancels all requests with the NS_BINDING_ABORTED error code. This propagates to the requests's imgStatusTracker::RecordStopRequest which puts it into the error state. It then gets applied to the image's status tracker's imgStatusTracker::(Apply)Difference which propagates the error. This then synchronously notifies the document's mozila::dom::ImageDocument::OnStopRequest which displays the error message. In case it is relevant, note that NS_BINDING_ABORTED has been lost at this point.

I was also able to reproduce this with a partly loaded image in a web page, although the error was not visible until the next repaint.