stack grows too deep during GC?

RESOLVED WORKSFORME

Status

()

Core
JavaScript Engine
P2
normal
RESOLVED WORKSFORME
7 years ago
4 years ago

People

(Reporter: gal, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Comment 1

7 years ago
Observed with the compartments patch queue.
Priority: -- → P2
Version: 1.9.2 Branch → Trunk

Comment 2

7 years ago
The first stack trace contains assureThingIsAligned. This is a debug-only method that does not call any GC-marking. It could be that the stack is damaged.
This stack can't be correct as Igor said.

The summary of the failing test-case is:
var summary = 'Do not assert: fp->slots + fp->script->nfixed + ' +
  'js_ReconstructStackDepth(cx, fp->script, fp->regs->pc) == fp->regs->sp';
Created attachment 481248 [details] [diff] [review]
Likely beginning of this...

I think I hit this yesterday, a jstestbrowser run eventually got stuck and breaking in gdb showed me this stack. This is the part that was easily captureable, but I still have the core file if more info from it would be helpful.
The reason for this was actually that the brain transplants branch was leaking everything when running reftests, which lead to a massive heap etc, which lead to an impressive number of things to GC. That's been fixed since, and I'm not sure there's really anything else we need to do here.
Resolving based on comment 5.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.