Use js.msg when CSP blocks eval

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: evilpie)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Comment 1

7 years ago
I'll fix this in bug 592664 after all.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 592664
(Reporter)

Comment 2

7 years ago
Sorry. No coffee yet. Will fix.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Reporter)

Comment 3

7 years ago
Created attachment 481245 [details] [diff] [review]
v1
Assignee: general → jorendorff
Attachment #481245 - Flags: review?(brendan)
Comment on attachment 481245 [details] [diff] [review]
v1

r=me with a double-check that caps isn't double-reporting.

/be
Attachment #481245 - Flags: review?(brendan) → review+
(Reporter)

Comment 5

7 years ago
Do you mean a JS_ASSERT or an actual "if (!cx->throwing)" around the JS_ReportErrorNumber calls?
(In reply to comment #5)
> Do you mean a JS_ASSERT or an actual "if (!cx->throwing)" around the
> JS_ReportErrorNumber calls?

Or just inspect the caps code (I tried a grep and saw some Report matches, so was not sure). But asserting is better, if JS_ReportErrorNumber doesn't already.

/be
(Assignee)

Comment 7

6 years ago
Created attachment 571782 [details] [diff] [review]
refreshed
Attachment #571782 - Flags: review?(jorendorff)
(Reporter)

Comment 8

6 years ago
Comment on attachment 571782 [details] [diff] [review]
refreshed

Confirmed, the hook for this in CAPS (nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction) does not report an error.

Thanks for digging this one up, evilpie.
Attachment #571782 - Flags: review?(jorendorff) → review+
(Assignee)

Updated

6 years ago
Assignee: jorendorff → evilpies
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/fec0c7e1b84c
https://hg.mozilla.org/mozilla-central/rev/fec0c7e1b84c
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Version: Other Branch → Trunk
You need to log in before you can comment on or make changes to this bug.