602334 - /en-US/firefox/search-engines/?sort=popular is not redirecting properly to remora

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

user agent:Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10

steps to reproduce:
1. In AMO Homepage,click on 'Search Tools' in the categories menu.

observed behavior:
The page isn't redirecting properly-
Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

 I see a 302 in the http headers and this works fine on Prod.

screenshot: http://screencast.com/t/hG8SkTcV2v

Comment 1

[Wil Clouser [:clouserw]]

Jeremy said he was moving a bunch of rewrites around on PAMO - is this fallout?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Specifically:

23:45:18.136: Network: GET https://preview.addons.mozilla.org/en-US/firefox/search-engines/?sort=popular [HTTP/1.1 302 Found 155ms]
23:45:18.317: Network: GET https://preview.addons.mozilla.org/en-US/firefox/browse/type:4/cat:all?sort=weeklydownloads [HTTP/1.1 301 MOVED PERMANENTLY 41ms]
23:45:18.358: Network: GET https://preview.addons.mozilla.org/en-US/firefox/search-tools/?sort=popular [HTTP/1.1 302 Found 38ms]

Comment 3

[Jeremy Orem [:oremj]]

The only difference is preview has:

-    RewriteRule ^((?:(?:/\w{2,3}(?:-\w{2})?)(?:/(?:firefox|seamonkey|thunderbird|mobile|sunbird))?)?/browse/type:[1-3](?:/cat:[^/]+)?/?)$ /z$1 [PT]
+    RewriteRule ^((?:(?:/\w{2,3}(?:-\w{2})?)(?:/(?:firefox|seamonkey|thunderbird|mobile|sunbird))?)?/browse/type:[1-4](?:/cat:[^/]+)?/?)$ /z$1 [PT]


+    RewriteRule ^((?:(?:/\w{2,3}(?:-\w{2})?)(?:/(?:firefox|seamonkey|thunderbird|mobile|sunbird))?)?/search-tools.*)$ /z$1 [PT]

Comment 4

[Jeremy Orem [:oremj]]

I've switched to type:[1-3] as recommended by Jeff.

Comment 5

[krupa raj[:krupa]]

The redirect works fine and loads https://preview.addons.mozilla.org/en-US/firefox/browse/type:4