nanojit: make Register a non-numeric type on ARM

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: njn, Assigned: jbramley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

8 years ago
Bug 599251 introduced the non-numeric Register type.  This back-end doesn't use it yet.  It should.  See the i386/X64 back-ends for examples.

This'll be easier once the codegen macros have been converted to functions (bug 592223).

Comment 1

8 years ago
Created attachment 485936 [details] [diff] [review]
fixup winmo

winmo is puking on R0,D7 usage in First/LastRegNum.

I'm not a big fan of keeping winmo going but if this is all it takes...
Attachment #485936 - Flags: review?(Jacob.Bramley)
(Assignee)

Comment 2

8 years ago
Comment on attachment 485936 [details] [diff] [review]
fixup winmo

It looks sensible, but does it belong in this bug?
Attachment #485936 - Flags: review?(Jacob.Bramley) → review+
(Assignee)

Updated

8 years ago
OS: Mac OS X → All
Hardware: x86 → ARM

Comment 3

8 years ago
Comment on attachment 485936 [details] [diff] [review]
fixup winmo

As the change to Register caused this issue I piggybacked this fix here.  But yes, I suppose a new bug could have been opened for it.

Anyway it has landed and will mark the patch as obsolete.

http://hg.mozilla.org/projects/nanojit-central/rev/ec207b83f9d8

Updated

8 years ago
Attachment #485936 - Attachment is obsolete: true
(Reporter)

Comment 4

8 years ago
http://hg.mozilla.org/tracemonkey/rev/60c2099aca88
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey

Comment 5

8 years ago
http://hg.mozilla.org/tamarin-redux/rev/b986959fbce5

clearing scoreboard since original issue still needs addressing.
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/60c2099aca88
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.