602457 - [RTL] Favicons in about:home are not on the right side

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: RTL abouT:home

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; en-US; rv:2.0b7pre)
Gecko/20101006 Firefox/4.0b7pre Fennec/4.0b1pre 

Device HTC Desire and Motorola Droid 2

Steps to reproduce:
1. instal plugin from: http://people.mozilla.com/~nhirata/html_tp/installplugin.html
2. go to the control panel -> preferences, and set the browser to Arabic

Expected result:
- the favicons should be on the right side

Actual result:
- the favicons are still left aligned

Note: is this is intentioned there is an inconsistency between about:home look and awesome bar where favicons are in the right side

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Just for clarification, Ioana means the favicons used in the about:home page itself, not the favicon button.

The icons used for "Tabs from other..." row and the "Recommended add-ons" sections are still on the left side.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Not sure if there a better way for doing RTL theme for web pages (I've asked to pascalc and Rik)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 481813 [details] [diff] [review]
Patch

Looks ok to me.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/f7791bfdac8e

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This bug as well as the arrow bug 602888 has been verified:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre)Gecko/20101011 Firefox/4.0b8pre Fennec/4.0b2pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101011 Firefox/4.0b8pre Fennec/4.0b2pre

About first run is still LTR, opening a new bug. Bug 603414